• Tvrtko Ursulin's avatar
    drm/i915: Fix premature LRC unpin in GuC mode · f4e2dece
    Tvrtko Ursulin authored
    In GuC mode LRC pinning lifetime depends exclusively on the
    request liftime. Since that is terminated by the seqno update
    that opens up a race condition between GPU finishing writing
    out the context image and the driver unpinning the LRC.
    
    To extend the LRC lifetime we will employ a similar approach
    to what legacy ringbuffer submission does.
    
    We will start tracking the last submitted context per engine
    and keep it pinned until it is replaced by another one.
    
    Note that the driver unload path is a bit fragile and could
    benefit greatly from efforts to unify the legacy and exec
    list submission code paths.
    
    At the moment i915_gem_context_fini has special casing for the
    two which are potentialy not needed, and also depends on
    i915_gem_cleanup_ringbuffer running before itself.
    
    v2:
     * Move pinning into engine->emit_request and actually fix
       the reference/unreference logic. (Chris Wilson)
    
     * ring->dev can be NULL on driver unload so use a different
       route towards it.
    
    v3:
     * Rebase.
     * Handle the reset path. (Chris Wilson)
     * Exclude default context from the pinning - it is impossible
       to get it right before default context special casing in
       general is eliminated.
    
    v4:
     * Rebased & moved context tracking to
       intel_logical_ring_advance_and_submit.
    Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
    Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Issue: VIZ-4277
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Nick Hoath <nicholas.hoath@intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1453976997-25424-1-git-send-email-tvrtko.ursulin@linux.intel.com
    f4e2dece
intel_lrc.c 79 KB