• Xie He's avatar
    drivers/net/wan/hdlc_fr: Improvements to the code of pvc_xmit · f5083d0c
    Xie He authored
    1. Keep the code for the normal (non-error) flow at the lowest
    indentation level. And use "goto drop" for all error handling.
    
    2. Replace code that pads short Ethernet frames with a "__skb_pad" call.
    
    3. Change "dev_kfree_skb" to "kfree_skb" in error handling code.
    "kfree_skb" is the correct function to call when dropping an skb due to
    an error. "dev_kfree_skb", which is an alias of "consume_skb", is for
    dropping skbs normally (not due to an error).
    
    Cc: Krzysztof Halasa <khc@pm.waw.pl>
    Cc: Stephen Hemminger <stephen@networkplumber.org>
    Signed-off-by: default avatarXie He <xie.he.0141@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f5083d0c
hdlc_fr.c 29.2 KB