• Roman Gushchin's avatar
    mm: memcontrol: rename memcg_kmem_enabled() · f7a449f7
    Roman Gushchin authored
    Currently there are two kmem-related helper functions with a confusing
    semantics: memcg_kmem_enabled() and mem_cgroup_kmem_disabled().
    
    The problem is that an obvious expectation
    memcg_kmem_enabled() == !mem_cgroup_kmem_disabled(),
    can be false.
    
    mem_cgroup_kmem_disabled() is similar to mem_cgroup_disabled(): it returns
    true only if CONFIG_MEMCG_KMEM is not set or the kmem accounting is
    disabled using a boot time kernel option "cgroup.memory=nokmem".  It never
    changes the value dynamically.
    
    memcg_kmem_enabled() is different: it always returns false until the first
    non-root memory cgroup will get online (assuming the kernel memory
    accounting is enabled).  It's goal is to improve the performance on
    systems without the cgroupfs mounted/memory controller enabled or on the
    systems with only the root memory cgroup.
    
    To make things more obvious and avoid potential bugs, let's rename
    memcg_kmem_enabled() to memcg_kmem_online().
    
    Link: https://lkml.kernel.org/r/20230213192922.1146370-1-roman.gushchin@linux.devSigned-off-by: default avatarRoman Gushchin <roman.gushchin@linux.dev>
    Acked-by: default avatarMuchun Song <songmuchun@bytedance.com>
    Acked-by: default avatarMichal Hocko <mhocko@suse.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Shakeel Butt <shakeelb@google.com>
    Cc: Dennis Zhou <dennis@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    f7a449f7
memcontrol.c 201 KB