• Liam Howlett's avatar
    tools: Rename __fallthrough to fallthrough · f7a858bf
    Liam Howlett authored
    Rename the fallthrough attribute to better align with the kernel
    version.  Copy the definition from include/linux/compiler_attributes.h
    including the #else clause.  Adding the #else clause allows the tools
    compiler.h header to drop the check for a definition entirely and keeps
    both definitions together.
    
    Change any __fallthrough statements to fallthrough anywhere it was used
    within perf.
    
    This allows other tools to use the same key word as the kernel.
    
    Committer notes:
    
    Did some missing conversions to:
    
      builtin-list.c
    
    Also included gtk.h before the 'fallthrough' definition in:
    
      tools/perf/ui/gtk/hists.c
      tools/perf/ui/gtk/helpline.c
      tools/perf/ui/gtk/browser.c
    
    As it is the arg name for a macro in glib.h:
    
      /var/home/acme/git/perf-tools-next/tools/include/linux/compiler-gcc.h:16:55: error: missing binary operator before token "("
         16 | # define fallthrough                    __attribute__((__fallthrough__))
            |                                                       ^
      /usr/include/glib-2.0/glib/gmacros.h:637:28: note: in expansion of macro ‘fallthrough’
        637 | #if g_macro__has_attribute(fallthrough)
    Reviewed-by: default avatarMiguel Ojeda <ojeda@kernel.org>
    Signed-off-by: default avatarLiam Howlett <Liam.Howlett@oracle.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Miguel Ojeda <ojeda@kernel.org>
    Cc: Nathan Chancellor <nathan@kernel.org>
    Cc: Nick Desaulniers <ndesaulniers@google.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    Cc: Tom Rix <trix@redhat.com>
    Cc: linux-sparse@vger.kernel.org <linux-sparse@vger.kernel.org>
    Cc: llvm@lists.linux.dev <llvm@lists.linux.dev>
    Link: https://lore.kernel.org/r/20221125154947.2163498-1-Liam.Howlett@oracle.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    f7a858bf
helpline.c 1.16 KB