• Mike Snitzer's avatar
    dm: fix improper splitting for abnormal bios · f7b58a69
    Mike Snitzer authored
    "Abnormal" bios include discards, write zeroes and secure erase. By no
    longer passing the calculated 'len' pointer, commit 7dd06a25 ("dm:
    allow dm_accept_partial_bio() for dm_io without duplicate bios") took a
    senseless approach to disallowing dm_accept_partial_bio() from working
    for duplicate bios processed using __send_duplicate_bios().
    
    It inadvertently and incorrectly stopped the use of 'len' when
    initializing a target's io (in alloc_tio). As such the resulting tio
    could address more area of a device than it should.
    
    For example, when discarding an entire DM striped device with the
    following DM table:
     vg-lvol0: 0 159744 striped 2 128 7:0 2048 7:1 2048
     vg-lvol0: 159744 45056 striped 2 128 7:2 2048 7:3 2048
    
    Before this fix:
    
     device-mapper: striped: target_stripe=0, bdev=7:0, start=2048 len=102400
     blkdiscard: attempt to access beyond end of device
     loop0: rw=2051, sector=2048, nr_sectors = 102400 limit=81920
    
     device-mapper: striped: target_stripe=1, bdev=7:1, start=2048 len=102400
     blkdiscard: attempt to access beyond end of device
     loop1: rw=2051, sector=2048, nr_sectors = 102400 limit=81920
    
    After this fix;
    
     device-mapper: striped: target_stripe=0, bdev=7:0, start=2048 len=79872
     device-mapper: striped: target_stripe=1, bdev=7:1, start=2048 len=79872
    
    Fixes: 7dd06a25 ("dm: allow dm_accept_partial_bio() for dm_io without duplicate bios")
    Cc: stable@vger.kernel.org
    Reported-by: default avatarOrange Kao <orange@aiven.io>
    Signed-off-by: default avatarMike Snitzer <snitzer@kernel.org>
    f7b58a69
dm.c 78.2 KB