• Steve Glendinning's avatar
    smsc911x: improve EEPROM loading timeout logic in open · f7efb6cc
    Steve Glendinning authored
    This patch from Juha Leppanen suppresses a false warning if the eeprom
    load succeeds on the very last attempt.
    
    Juha> In function smsc911x_open smsc911x_reg_read+udelay can be run 50
    Juha> times with timeout reaching -1, and the following if statetement
    Juha> does not catch the timeout and no warning is issued. Also if the
    Juha> 50th smsc911x_reg_read is GOOD, loop is exited with timeout as 0
    Juha> and bogus warning issued.  Replace testing order and --timeout
    Juha> instead of timeout-- and now max 50 smsc911x_reg_read's are done,
    Juha> with max 49 udelays.
    Signed-off-by: default avatarSteve Glendinning <steve.glendinning@smsc.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    f7efb6cc
smsc911x.c 55.2 KB