You need to sign in or sign up before continuing.
  • Primoz Fiser's avatar
    watchdog: da9062: da9063: use unlocked xfer function in restart · f8ee39b4
    Primoz Fiser authored
    Machine resets via da9062/da9063 PMICs are challenging since one needs
    to use special i2c atomic transfers due to the fact interrupts are
    disabled in such late system stages. This is the reason both PMICs don't
    use regmap and have instead opted for i2c_smbus_write_byte_data() in
    restart handlers.
    
    However extensive testing revealed that even using atomic safe function
    is not enough and occasional resets fail with error message "Failed to
    shutdown (err =  -11)". This is due to the fact that function
    i2c_smbus_write_byte_data() in turn calls __i2c_lock_bus_helper()
    which might fail with -EAGAIN when bus lock is already taken and cannot
    be released anymore.
    
    Thus replace i2c_smbus_write_byte_data() with unlocked flavor of
    i2c_smbus_xfer() function to avoid above dead-lock scenario. At this
    system stage we don't care about proper locking anymore and only want
    proper machine reset to be carried out.
    
    Signed-off-by: Primoz Fiser <primoz.fiser@norik...
    f8ee39b4
da9063_wdt.c 7.79 KB