• Dmitry Popov's avatar
    tcp: incoming connections might use wrong route under synflood · d66954a0
    Dmitry Popov authored
    There is a bug in cookie_v4_check (net/ipv4/syncookies.c):
    	flowi4_init_output(&fl4, 0, sk->sk_mark, RT_CONN_FLAGS(sk),
    			   RT_SCOPE_UNIVERSE, IPPROTO_TCP,
    			   inet_sk_flowi_flags(sk),
    			   (opt && opt->srr) ? opt->faddr : ireq->rmt_addr,
    			   ireq->loc_addr, th->source, th->dest);
    
    Here we do not respect sk->sk_bound_dev_if, therefore wrong dst_entry may be
    taken. This dst_entry is used by new socket (get_cookie_sock ->
    tcp_v4_syn_recv_sock), so its packets may take the wrong path.
    Signed-off-by: default avatarDmitry Popov <dp@highloadlab.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d66954a0
syncookies.c 10.5 KB