Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L linux
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Kirill Smelkov
  • linux
  • Repository
  • linux
  • arch
  • x86
  • kernel
  • dumpstack.c
Find file BlameHistoryPermalink
  • Dmitry Safonov's avatar
    x86/dumpstack: Add log_lvl to show_iret_regs() · fd07f802
    Dmitry Safonov authored Jun 29, 2020
    show_trace_log_lvl() provides x86 platform-specific way to unwind
    backtrace with a given log level. Unfortunately, registers dump(s) are
    not printed with the same log level - instead, KERN_DEFAULT is always
    used.
    
    Arista's switches uses quite common setup with rsyslog, where only
    urgent messages goes to console (console_log_level=KERN_ERR), everything
    else goes into /var/log/ as the console baud-rate often is indecently
    slow (9600 bps).
    
    Backtrace dumps without registers printed have proven to be as useful as
    morning standups. Furthermore, in order to introduce KERN_UNSUPPRESSED
    (which I believe is still the most elegant way to fix raciness of sysrq[1])
    the log level should be passed down the stack to register dumping
    functions. Besides, there is a potential use-case for printing traces
    with KERN_DEBUG level [2] (where registers dump shouldn't appear with
    higher log level).
    
    Add log_lvl parameter to show_iret_regs() as a preparation to add it
    to __show_regs() and show_regs_if_on_stack().
    
    [1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/
    [2]: https://lore.kernel.org/linux-doc/20190724170249.9644-1-dima@arista.com/
    
    
    
    Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Acked-by: default avatarPetr Mladek <pmladek@suse.com>
    Link: https://lkml.kernel.org/r/20200629144847.492794-2-dima@arista.com
    fd07f802
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7