• Ricardo Neri's avatar
    x86/mtrr: Skip cache flushes on CPUs with cache self-snooping · fd329f27
    Ricardo Neri authored
    Programming MTRR registers in multi-processor systems is a rather lengthy
    process. Furthermore, all processors must program these registers in lock
    step and with interrupts disabled; the process also involves flushing
    caches and TLBs twice. As a result, the process may take a considerable
    amount of time.
    
    On some platforms, this can lead to a large skew of the refined-jiffies
    clock source. Early when booting, if no other clock is available (e.g.,
    booting with hpet=disabled), the refined-jiffies clock source is used to
    monitor the TSC clock source. If the skew of refined-jiffies is too large,
    Linux wrongly assumes that the TSC is unstable:
    
      clocksource: timekeeping watchdog on CPU1: Marking clocksource
                   'tsc-early' as unstable because the skew is too large:
      clocksource: 'refined-jiffies' wd_now: fffedc10 wd_last:
                   fffedb90 mask: ffffffff
      clocksource: 'tsc-early' cs_now: 5eccfddebc cs_last: 5e7e3303d4
                   mask: ffffffffffffffff
      tsc: Marking TSC unstable due to clocksource watchdog
    
    As per measurements, around 98% of the time needed by the procedure to
    program MTRRs in multi-processor systems is spent flushing caches with
    wbinvd(). As per the Section 11.11.8 of the Intel 64 and IA 32
    Architectures Software Developer's Manual, it is not necessary to flush
    caches if the CPU supports cache self-snooping. Thus, skipping the cache
    flushes can reduce by several tens of milliseconds the time needed to
    complete the programming of the MTRR registers:
    
    Platform                      	Before	   After
    104-core (208 Threads) Skylake  1437ms      28ms
      2-core (  4 Threads) Haswell   114ms       2ms
    Reported-by: default avatarMohammad Etemadi <mohammad.etemadi@intel.com>
    Signed-off-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
    Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
    Cc: Borislav Petkov <bp@suse.de>
    Cc: Alan Cox <alan.cox@intel.com>
    Cc: Tony Luck <tony.luck@intel.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Cc: Andi Kleen <andi.kleen@intel.com>
    Cc: Hans de Goede <hdegoede@redhat.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Jordan Borgner <mail@jordan-borgner.de>
    Cc: "Ravi V. Shankar" <ravi.v.shankar@intel.com>
    Cc: Ricardo Neri <ricardo.neri@intel.com>
    Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Peter Feiner <pfeiner@google.com>
    Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
    Link: https://lkml.kernel.org/r/1561689337-19390-3-git-send-email-ricardo.neri-calderon@linux.intel.com
    fd329f27
generic.c 23.4 KB