• Tony Lindgren's avatar
    serial: 8250: omap: Fix life cycle issues for interrupt handlers · fef4f600
    Tony Lindgren authored
    We have the struct uart_8250_port instance recycled on device rebind while
    the struct omap8250_priv instance is not. For the console uart,
    __tty_hangup() does not call tty->ops->hangup() as cons_filp stays open,
    and uart shutdown won't get called. This means we have a stale
    priv->wakeirq handler around after unbind, and port->irq is not freed on
    unbind.
    
    There's no need to claim the interrupts on startup. We can fix this and
    simplify the driver a bit by claiming the interrupts in probe, and clearing
    them on remove. For the device interrupt, we can use devm_request_irq().
    
    To do this, we change omap8250_irq() to use struct omap8250_priv data
    directly so we don't have to wait for the assigned port from
    serial8250_register_8250_port().
    
    We must also drop IRQF_SHARED to set IRQ_NOAUTOEN to avoid spurious
    interrupts until the port has been registered. There's no need for
    IRQF_SHARED for 8250_omap, the serial port interrupt lines are dedicated
    lines.
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Link: https://lore.kernel.org/r/20230508082014.23083-4-tony@atomide.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    fef4f600
8250_omap.c 47.2 KB