• Douglas Anderson's avatar
    clk: qcom: lpass-sc7180: Fix pm_runtime usage · ff1ccf59
    Douglas Anderson authored
    The sc7180 lpass clock controller's pm_runtime usage wasn't broken
    quite as spectacularly as the sc7280's pm_runtime usage, but it was
    still broken. Putting some printouts in at boot showed me this (with
    serial console enabled, which makes the prints slow and thus changes
    timing):
      [    3.109951] DOUG: my_pm_clk_resume, usage=1
      [    3.114767] DOUG: my_pm_clk_resume, usage=1
      [    3.664443] DOUG: my_pm_clk_suspend, usage=0
      [    3.897566] DOUG: my_pm_clk_suspend, usage=0
      [    3.910137] DOUG: my_pm_clk_resume, usage=1
      [    3.923217] DOUG: my_pm_clk_resume, usage=0
      [    4.440116] DOUG: my_pm_clk_suspend, usage=-1
      [    4.444982] DOUG: my_pm_clk_suspend, usage=0
      [   14.170501] DOUG: my_pm_clk_resume, usage=1
      [   14.176245] DOUG: my_pm_clk_resume, usage=0
    
    ...or this w/out serial console:
      [    0.556139] DOUG: my_pm_clk_resume, usage=1
      [    0.556279] DOUG: my_pm_clk_resume, usage=1
      [    1.058422] DOUG: my_pm_clk_suspend, usage=-1
      [    1.058464] DOUG: my_pm_clk_suspend, usage=0
      [    1.186250] DOUG: my_pm_clk_resume, usage=1
      [    1.186292] DOUG: my_pm_clk_resume, usage=0
      [    1.731536] DOUG: my_pm_clk_suspend, usage=-1
      [    1.731557] DOUG: my_pm_clk_suspend, usage=0
      [   10.288910] DOUG: my_pm_clk_resume, usage=1
      [   10.289496] DOUG: my_pm_clk_resume, usage=0
    
    It seems to be doing roughly the right sequence of calls, but just
    like with sc7280 this is more by luck than anything. Having a usage of
    -1 is just not OK.
    
    Let's fix this like we did with sc7280.
    Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
    Fixes: ce8c195e ("clk: qcom: lpasscc: Introduce pm autosuspend for SC7180")
    Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
    Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
    Link: https://lore.kernel.org/r/20221104064055.2.I49b25b9bda9430fc7ea21e5a708ca5a0aced2798@changeid
    ff1ccf59
lpasscorecc-sc7180.c 12.9 KB