• Arvind Sankar's avatar
    x86/purgatory: Add -fno-stack-protector · ff58155c
    Arvind Sankar authored
    The purgatory Makefile removes -fstack-protector options if they were
    configured in, but does not currently add -fno-stack-protector.
    
    If gcc was configured with the --enable-default-ssp configure option,
    this results in the stack protector still being enabled for the
    purgatory (absent distro-specific specs files that might disable it
    again for freestanding compilations), if the main kernel is being
    compiled with stack protection enabled (if it's disabled for the main
    kernel, the top-level Makefile will add -fno-stack-protector).
    
    This will break the build since commit
      e4160b2e ("x86/purgatory: Fail the build if purgatory.ro has missing symbols")
    and prior to that would have caused runtime failure when trying to use
    kexec.
    
    Explicitly add -fno-stack-protector to avoid this, as done in other
    Makefiles that need to disable the stack protector.
    Reported-by: default avatarGabriel C <nix.or.die@googlemail.com>
    Signed-off-by: default avatarArvind Sankar <nivedita@alum.mit.edu>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    ff58155c
Makefile 2.51 KB