Commit 000c74d9 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman

usb: fix sillies in the metro USB driver

Bits noticed doing the termios conversion
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 79d75320
...@@ -130,20 +130,14 @@ static void metrousb_read_int_callback(struct urb *urb) ...@@ -130,20 +130,14 @@ static void metrousb_read_int_callback(struct urb *urb)
/* Set the data read from the usb port into the serial port buffer. */ /* Set the data read from the usb port into the serial port buffer. */
tty = tty_port_tty_get(&port->port); tty = tty_port_tty_get(&port->port);
if (!tty) {
dev_err(&port->dev, "%s - bad tty pointer - exiting\n",
__func__);
return;
}
if (tty && urb->actual_length) { if (tty && urb->actual_length) {
/* Loop through the data copying each byte to the tty layer. */ /* Loop through the data copying each byte to the tty layer. */
tty_insert_flip_string(tty, data, urb->actual_length); tty_insert_flip_string(tty, data, urb->actual_length);
/* Force the data to the tty layer. */ /* Force the data to the tty layer. */
tty_flip_buffer_push(tty); tty_flip_buffer_push(tty);
tty_kref_put(tty);
} }
tty_kref_put(tty);
/* Set any port variables. */ /* Set any port variables. */
spin_lock_irqsave(&metro_priv->lock, flags); spin_lock_irqsave(&metro_priv->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment