Commit 04cc3c8a authored by David Matlack's avatar David Matlack Committed by Greg Kroah-Hartman

staging: slicoss: remove gratuitous debug infrastructure

As per the TODO file, this patch removes the gratuitous debug
infrastructure. As an extra incentive for removing this code,
the debugfs files are not cleaned up properly. For example, if
register_netdev() fails in slic_entry_probe() then all debugfs
files get left behind, even after the driver module is unloaded.
Touching these files quickly leads to an oops.
Signed-off-by: default avatarDavid Matlack <dmatlack@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 563dce37
...@@ -18,7 +18,6 @@ TODO: ...@@ -18,7 +18,6 @@ TODO:
use ethtool instead use ethtool instead
- reorder code to elminate use of forward declarations - reorder code to elminate use of forward declarations
- don't keep private linked list of drivers. - don't keep private linked list of drivers.
- remove all the gratiutous debug infrastructure
- use PCI_DEVICE() - use PCI_DEVICE()
- do ethtool correctly using ethtool_ops - do ethtool correctly using ethtool_ops
- NAPI? - NAPI?
......
...@@ -310,8 +310,6 @@ struct sliccard { ...@@ -310,8 +310,6 @@ struct sliccard {
u32 loadtimerset; u32 loadtimerset;
uint config_set; uint config_set;
struct slic_config config; struct slic_config config;
struct dentry *debugfs_dir;
struct dentry *debugfs_cardinfo;
struct adapter *master; struct adapter *master;
struct adapter *adapter[SLIC_MAX_PORTS]; struct adapter *adapter[SLIC_MAX_PORTS];
struct sliccard *next; struct sliccard *next;
...@@ -450,7 +448,6 @@ struct adapter { ...@@ -450,7 +448,6 @@ struct adapter {
u32 pingtimerset; u32 pingtimerset;
struct timer_list loadtimer; struct timer_list loadtimer;
u32 loadtimerset; u32 loadtimerset;
struct dentry *debugfs_entry;
struct slic_spinlock upr_lock; struct slic_spinlock upr_lock;
struct slic_spinlock bit64reglock; struct slic_spinlock bit64reglock;
struct slic_rspqueue rspqueue; struct slic_rspqueue rspqueue;
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment