Commit 05b01dd9 authored by Milo Kim's avatar Milo Kim Committed by Krzysztof Kozlowski

ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'

This patch enables getting a HPD GPIO descriptor quicker.
The exynos-hdmi driver uses "hpd" for HDMI hot plug detection.

	static int hdmi_resources_init(struct hdmi_context *hdata)
	{
		...
		hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN);
		...
	}

This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring
GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor.

However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver
always retries to get a GPIO descriptor because the first GPIO suffix is not
'gpio' but 'gpios'. So you always see the debug message below.

	of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@14530000[0]'

Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'.
Acked-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarAndrzej Hajda <a.hajda@samsung.com>
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarMilo Kim <woogyom.kim@gmail.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
parent 5a5232d1
...@@ -9,7 +9,7 @@ Required properties: ...@@ -9,7 +9,7 @@ Required properties:
- reg: physical base address of the hdmi and length of memory mapped - reg: physical base address of the hdmi and length of memory mapped
region. region.
- interrupts: interrupt number to the cpu. - interrupts: interrupt number to the cpu.
- hpd-gpio: following information about the hotplug gpio pin. - hpd-gpios: following information about the hotplug gpio pin.
a) phandle of the gpio controller node. a) phandle of the gpio controller node.
b) pin number within the gpio controller. b) pin number within the gpio controller.
c) optional flags and pull up/down. c) optional flags and pull up/down.
...@@ -56,7 +56,7 @@ Example: ...@@ -56,7 +56,7 @@ Example:
compatible = "samsung,exynos4212-hdmi"; compatible = "samsung,exynos4212-hdmi";
reg = <0x14530000 0x100000>; reg = <0x14530000 0x100000>;
interrupts = <0 95 0>; interrupts = <0 95 0>;
hpd-gpio = <&gpx3 7 1>; hpd-gpios = <&gpx3 7 1>;
ddc = <&hdmi_ddc_node>; ddc = <&hdmi_ddc_node>;
phy = <&hdmi_phy_node>; phy = <&hdmi_phy_node>;
samsung,syscon-phandle = <&pmu_system_controller>; samsung,syscon-phandle = <&pmu_system_controller>;
......
...@@ -269,7 +269,7 @@ fimd_dpi_ep: endpoint { ...@@ -269,7 +269,7 @@ fimd_dpi_ep: endpoint {
}; };
&hdmi { &hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd>; pinctrl-0 = <&hdmi_hpd>;
hdmi-en-supply = <&hdmi_en>; hdmi-en-supply = <&hdmi_en>;
......
...@@ -227,7 +227,7 @@ &fimc_3 { ...@@ -227,7 +227,7 @@ &fimc_3 {
}; };
&hdmi { &hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd>; pinctrl-0 = <&hdmi_hpd>;
vdd-supply = <&ldo8_reg>; vdd-supply = <&ldo8_reg>;
......
...@@ -152,7 +152,7 @@ &fimd { ...@@ -152,7 +152,7 @@ &fimd {
}; };
&hdmi { &hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_LOW>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_LOW>;
vdd_osc-supply = <&ldo10_reg>; vdd_osc-supply = <&ldo10_reg>;
vdd_pll-supply = <&ldo8_reg>; vdd_pll-supply = <&ldo8_reg>;
vdd-supply = <&ldo8_reg>; vdd-supply = <&ldo8_reg>;
......
...@@ -116,7 +116,7 @@ &fimd { ...@@ -116,7 +116,7 @@ &fimd {
}; };
&hdmi { &hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
}; };
&i2c_0 { &i2c_0 {
......
...@@ -260,7 +260,7 @@ &fimd { ...@@ -260,7 +260,7 @@ &fimd {
}; };
&hdmi { &hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>; pinctrl-0 = <&hdmi_hpd_irq>;
phy = <&hdmiphy>; phy = <&hdmiphy>;
......
...@@ -91,7 +91,7 @@ &fimd { ...@@ -91,7 +91,7 @@ &fimd {
}; };
&hdmi { &hdmi {
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>; pinctrl-0 = <&hdmi_hpd_irq>;
phy = <&hdmiphy>; phy = <&hdmiphy>;
......
...@@ -179,7 +179,7 @@ &fimd { ...@@ -179,7 +179,7 @@ &fimd {
&hdmi { &hdmi {
status = "okay"; status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>; pinctrl-0 = <&hdmi_hpd_irq>;
ddc = <&i2c_2>; ddc = <&i2c_2>;
......
...@@ -130,7 +130,7 @@ &fimd { ...@@ -130,7 +130,7 @@ &fimd {
&hdmi { &hdmi {
status = "okay"; status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>; pinctrl-0 = <&hdmi_hpd_irq>;
}; };
......
...@@ -250,7 +250,7 @@ &cpu4 { ...@@ -250,7 +250,7 @@ &cpu4 {
&hdmi { &hdmi {
status = "okay"; status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>; pinctrl-0 = <&hdmi_hpd_irq>;
......
...@@ -179,7 +179,7 @@ &fimd { ...@@ -179,7 +179,7 @@ &fimd {
&hdmi { &hdmi {
status = "okay"; status = "okay";
hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>; hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&hdmi_hpd_irq>; pinctrl-0 = <&hdmi_hpd_irq>;
ddc = <&i2c_2>; ddc = <&i2c_2>;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment