Commit 061a5ad7 authored by Fabio Estevam's avatar Fabio Estevam Committed by Dmitry Torokhov

Input: imx_keypad - use the preferred form for passing a size of a struct

According to Documentation/CodingStyle - Chapter 14:

"The preferred form for passing a size of a struct is the following:

        p = kmalloc(sizeof(*p), ...);

The alternative form where struct name is spelled out hurts readability and
introduces an opportunity for a bug when the pointer variable type is changed
but the corresponding sizeof that is passed to a memory allocator is not."

So do it as recommended.
Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent aa104b1a
...@@ -448,8 +448,7 @@ static int imx_keypad_probe(struct platform_device *pdev) ...@@ -448,8 +448,7 @@ static int imx_keypad_probe(struct platform_device *pdev)
return -ENOMEM; return -ENOMEM;
} }
keypad = devm_kzalloc(&pdev->dev, sizeof(struct imx_keypad), keypad = devm_kzalloc(&pdev->dev, sizeof(*keypad), GFP_KERNEL);
GFP_KERNEL);
if (!keypad) { if (!keypad) {
dev_err(&pdev->dev, "not enough memory for driver data\n"); dev_err(&pdev->dev, "not enough memory for driver data\n");
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment