Commit 068a565a authored by Olof Johansson's avatar Olof Johansson

Merge branch 'testing/driver-warnings' of...

Merge branch 'testing/driver-warnings' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc into fixes

A collection of warning fixes on non-ARM code from Arnd Bergmann:

* 'testing/driver-warnings' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc:
  ARM: s3c: mark s3c2440_clk_add as __init_refok
  spi/s3c64xx: use correct dma_transfer_direction type
  pcmcia: sharpsl: don't discard sharpsl_pcmcia_ops
  USB: EHCI: mark ehci_orion_conf_mbus_windows __devinit
  mm/slob: use min_t() to compare ARCH_SLAB_MINALIGN
  SCSI: ARM: make fas216_dumpinfo function conditional
  SCSI: ARM: ncr5380/oak uses no interrupts
parents b55a7a5f 5276b687
...@@ -163,7 +163,7 @@ static struct clk_lookup s3c2440_clk_lookup[] = { ...@@ -163,7 +163,7 @@ static struct clk_lookup s3c2440_clk_lookup[] = {
CLKDEV_INIT(NULL, "clk_uart_baud3", &s3c2440_clk_fclk_n), CLKDEV_INIT(NULL, "clk_uart_baud3", &s3c2440_clk_fclk_n),
}; };
static int s3c2440_clk_add(struct device *dev, struct subsys_interface *sif) static int __init_refok s3c2440_clk_add(struct device *dev, struct subsys_interface *sif)
{ {
struct clk *clock_upll; struct clk *clock_upll;
struct clk *clock_h; struct clk *clock_h;
......
...@@ -194,7 +194,7 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt) ...@@ -194,7 +194,7 @@ static void sharpsl_pcmcia_socket_suspend(struct soc_pcmcia_socket *skt)
sharpsl_pcmcia_init_reset(skt); sharpsl_pcmcia_init_reset(skt);
} }
static struct pcmcia_low_level sharpsl_pcmcia_ops __initdata = { static struct pcmcia_low_level sharpsl_pcmcia_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.hw_init = sharpsl_pcmcia_hw_init, .hw_init = sharpsl_pcmcia_hw_init,
.socket_state = sharpsl_pcmcia_socket_state, .socket_state = sharpsl_pcmcia_socket_state,
......
...@@ -179,6 +179,7 @@ static void print_SCp(struct scsi_pointer *SCp, const char *prefix, const char * ...@@ -179,6 +179,7 @@ static void print_SCp(struct scsi_pointer *SCp, const char *prefix, const char *
SCp->buffers_residual, suffix); SCp->buffers_residual, suffix);
} }
#ifdef CHECK_STRUCTURE
static void fas216_dumpinfo(FAS216_Info *info) static void fas216_dumpinfo(FAS216_Info *info)
{ {
static int used = 0; static int used = 0;
...@@ -223,7 +224,6 @@ static void fas216_dumpinfo(FAS216_Info *info) ...@@ -223,7 +224,6 @@ static void fas216_dumpinfo(FAS216_Info *info)
info->internal_done, info->magic_end); info->internal_done, info->magic_end);
} }
#ifdef CHECK_STRUCTURE
static void __fas216_checkmagic(FAS216_Info *info, const char *func) static void __fas216_checkmagic(FAS216_Info *info, const char *func)
{ {
int corruption = 0; int corruption = 0;
......
...@@ -21,6 +21,7 @@ ...@@ -21,6 +21,7 @@
/*#define PSEUDO_DMA*/ /*#define PSEUDO_DMA*/
#define OAKSCSI_PUBLIC_RELEASE 1 #define OAKSCSI_PUBLIC_RELEASE 1
#define DONT_USE_INTR
#define priv(host) ((struct NCR5380_hostdata *)(host)->hostdata) #define priv(host) ((struct NCR5380_hostdata *)(host)->hostdata)
#define NCR5380_local_declare() void __iomem *_base #define NCR5380_local_declare() void __iomem *_base
......
...@@ -132,7 +132,7 @@ ...@@ -132,7 +132,7 @@
struct s3c64xx_spi_dma_data { struct s3c64xx_spi_dma_data {
unsigned ch; unsigned ch;
enum dma_data_direction direction; enum dma_transfer_direction direction;
enum dma_ch dmach; enum dma_ch dmach;
struct property *dma_prop; struct property *dma_prop;
}; };
...@@ -1067,11 +1067,11 @@ static int __devinit s3c64xx_spi_get_dmares( ...@@ -1067,11 +1067,11 @@ static int __devinit s3c64xx_spi_get_dmares(
if (tx) { if (tx) {
dma_data = &sdd->tx_dma; dma_data = &sdd->tx_dma;
dma_data->direction = DMA_TO_DEVICE; dma_data->direction = DMA_MEM_TO_DEV;
chan_str = "tx"; chan_str = "tx";
} else { } else {
dma_data = &sdd->rx_dma; dma_data = &sdd->rx_dma;
dma_data->direction = DMA_FROM_DEVICE; dma_data->direction = DMA_DEV_TO_MEM;
chan_str = "rx"; chan_str = "rx";
} }
......
...@@ -160,7 +160,7 @@ static const struct hc_driver ehci_orion_hc_driver = { ...@@ -160,7 +160,7 @@ static const struct hc_driver ehci_orion_hc_driver = {
.clear_tt_buffer_complete = ehci_clear_tt_buffer_complete, .clear_tt_buffer_complete = ehci_clear_tt_buffer_complete,
}; };
static void __init static void __devinit
ehci_orion_conf_mbus_windows(struct usb_hcd *hcd, ehci_orion_conf_mbus_windows(struct usb_hcd *hcd,
const struct mbus_dram_target_info *dram) const struct mbus_dram_target_info *dram)
{ {
......
...@@ -429,7 +429,7 @@ static __always_inline void * ...@@ -429,7 +429,7 @@ static __always_inline void *
__do_kmalloc_node(size_t size, gfp_t gfp, int node, unsigned long caller) __do_kmalloc_node(size_t size, gfp_t gfp, int node, unsigned long caller)
{ {
unsigned int *m; unsigned int *m;
int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN); int align = max_t(size_t, ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
void *ret; void *ret;
gfp &= gfp_allowed_mask; gfp &= gfp_allowed_mask;
...@@ -502,7 +502,7 @@ void kfree(const void *block) ...@@ -502,7 +502,7 @@ void kfree(const void *block)
sp = virt_to_page(block); sp = virt_to_page(block);
if (PageSlab(sp)) { if (PageSlab(sp)) {
int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN); int align = max_t(size_t, ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
unsigned int *m = (unsigned int *)(block - align); unsigned int *m = (unsigned int *)(block - align);
slob_free(m, *m + align); slob_free(m, *m + align);
} else } else
...@@ -521,7 +521,7 @@ size_t ksize(const void *block) ...@@ -521,7 +521,7 @@ size_t ksize(const void *block)
sp = virt_to_page(block); sp = virt_to_page(block);
if (PageSlab(sp)) { if (PageSlab(sp)) {
int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN); int align = max_t(size_t, ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
unsigned int *m = (unsigned int *)(block - align); unsigned int *m = (unsigned int *)(block - align);
return SLOB_UNITS(*m) * SLOB_UNIT; return SLOB_UNITS(*m) * SLOB_UNIT;
} else } else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment