Commit 0736390b authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nicholas Bellinger

usb-gadget/f_phonet: use per-attribute show and store methods

To simplify the configfs interface and remove boilerplate code that also
causes binary bloat.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarAndrzej Pietrasiewicz <andrzej.p@samsung.com>
Acked-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 3da5e4c1
...@@ -589,21 +589,6 @@ static inline struct f_phonet_opts *to_f_phonet_opts(struct config_item *item) ...@@ -589,21 +589,6 @@ static inline struct f_phonet_opts *to_f_phonet_opts(struct config_item *item)
func_inst.group); func_inst.group);
} }
CONFIGFS_ATTR_STRUCT(f_phonet_opts);
static ssize_t f_phonet_attr_show(struct config_item *item,
struct configfs_attribute *attr,
char *page)
{
struct f_phonet_opts *opts = to_f_phonet_opts(item);
struct f_phonet_opts_attribute *f_phonet_opts_attr =
container_of(attr, struct f_phonet_opts_attribute, attr);
ssize_t ret = 0;
if (f_phonet_opts_attr->show)
ret = f_phonet_opts_attr->show(opts, page);
return ret;
}
static void phonet_attr_release(struct config_item *item) static void phonet_attr_release(struct config_item *item)
{ {
struct f_phonet_opts *opts = to_f_phonet_opts(item); struct f_phonet_opts *opts = to_f_phonet_opts(item);
...@@ -613,19 +598,17 @@ static void phonet_attr_release(struct config_item *item) ...@@ -613,19 +598,17 @@ static void phonet_attr_release(struct config_item *item)
static struct configfs_item_operations phonet_item_ops = { static struct configfs_item_operations phonet_item_ops = {
.release = phonet_attr_release, .release = phonet_attr_release,
.show_attribute = f_phonet_attr_show,
}; };
static ssize_t f_phonet_ifname_show(struct f_phonet_opts *opts, char *page) static ssize_t f_phonet_ifname_show(struct config_item *item, char *page)
{ {
return gether_get_ifname(opts->net, page, PAGE_SIZE); return gether_get_ifname(to_f_phonet_opts(item)->net, page, PAGE_SIZE);
} }
static struct f_phonet_opts_attribute f_phonet_ifname = CONFIGFS_ATTR_RO(f_phonet_, ifname);
__CONFIGFS_ATTR_RO(ifname, f_phonet_ifname_show);
static struct configfs_attribute *phonet_attrs[] = { static struct configfs_attribute *phonet_attrs[] = {
&f_phonet_ifname.attr, &f_phonet_attr_ifname,
NULL, NULL,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment