Commit 07f651c7 authored by Eric Miao's avatar Eric Miao

[ARM] pxafb: avoid the racing condition in pxafb_smart_thread

fbi->state change shall really be protected by fbi->ctrlr_lock, where
the change is sheltered. There is a possibility that pxafb_smart_thread
will start update the LCD panel when fbi->state == C_ENABLE, while
all other initialization isn't done.
Signed-off-by: default avatarEric Miao <eric.miao@marvell.com>
parent 69bdea70
...@@ -794,11 +794,15 @@ static int pxafb_smart_thread(void *arg) ...@@ -794,11 +794,15 @@ static int pxafb_smart_thread(void *arg)
if (try_to_freeze()) if (try_to_freeze())
continue; continue;
mutex_lock(&fbi->ctrlr_lock);
if (fbi->state == C_ENABLE) { if (fbi->state == C_ENABLE) {
inf->smart_update(&fbi->fb); inf->smart_update(&fbi->fb);
complete(&fbi->refresh_done); complete(&fbi->refresh_done);
} }
mutex_unlock(&fbi->ctrlr_lock);
set_current_state(TASK_INTERRUPTIBLE); set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(30 * HZ / 1000); schedule_timeout(30 * HZ / 1000);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment