Commit 09530751 authored by Julia Lawall's avatar Julia Lawall Committed by Lee Jones

mfd: max8925-i2c: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any use, on every possible execution path through the function.  The static
has no benefit, and dropping it reduces the code size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
   2579     240      16    2835     b13 drivers/mfd/max8925-i2c.o

after:
   text    data     bss     dec     hex filename
   2531     240       8    2779     adb drivers/mfd/max8925-i2c.o
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Acked-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 45f80a9f
...@@ -151,7 +151,7 @@ static int max8925_probe(struct i2c_client *client, ...@@ -151,7 +151,7 @@ static int max8925_probe(struct i2c_client *client,
const struct i2c_device_id *id) const struct i2c_device_id *id)
{ {
struct max8925_platform_data *pdata = dev_get_platdata(&client->dev); struct max8925_platform_data *pdata = dev_get_platdata(&client->dev);
static struct max8925_chip *chip; struct max8925_chip *chip;
struct device_node *node = client->dev.of_node; struct device_node *node = client->dev.of_node;
if (node && !pdata) { if (node && !pdata) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment