Commit 0e30af1e authored by Paul Mackerras's avatar Paul Mackerras Committed by Jeff Garzik

[PATCH] module owner for ppp_synctty.c

This patch fixes ppp_synctty.c (used for doing PPP over some synchronous
serial HDLC links) so that it sets the owner field of the tty line
discipline it exports, rather than using MOD_INC/DEC_USE_COUNT.  This
is more or less from Stephen Hemminger.

Please apply.

Thanks,
Paul.
parent 4997bf53
...@@ -202,7 +202,6 @@ ppp_sync_open(struct tty_struct *tty) ...@@ -202,7 +202,6 @@ ppp_sync_open(struct tty_struct *tty)
struct syncppp *ap; struct syncppp *ap;
int err; int err;
MOD_INC_USE_COUNT;
ap = kmalloc(sizeof(*ap), GFP_KERNEL); ap = kmalloc(sizeof(*ap), GFP_KERNEL);
err = -ENOMEM; err = -ENOMEM;
if (ap == 0) if (ap == 0)
...@@ -236,7 +235,6 @@ ppp_sync_open(struct tty_struct *tty) ...@@ -236,7 +235,6 @@ ppp_sync_open(struct tty_struct *tty)
out_free: out_free:
kfree(ap); kfree(ap);
out: out:
MOD_DEC_USE_COUNT;
return err; return err;
} }
...@@ -276,7 +274,6 @@ ppp_sync_close(struct tty_struct *tty) ...@@ -276,7 +274,6 @@ ppp_sync_close(struct tty_struct *tty)
if (ap->tpkt != 0) if (ap->tpkt != 0)
kfree_skb(ap->tpkt); kfree_skb(ap->tpkt);
kfree(ap); kfree(ap);
MOD_DEC_USE_COUNT;
} }
/* /*
...@@ -404,6 +401,7 @@ ppp_sync_wakeup(struct tty_struct *tty) ...@@ -404,6 +401,7 @@ ppp_sync_wakeup(struct tty_struct *tty)
static struct tty_ldisc ppp_sync_ldisc = { static struct tty_ldisc ppp_sync_ldisc = {
.owner = THIS_MODULE,
.magic = TTY_LDISC_MAGIC, .magic = TTY_LDISC_MAGIC,
.name = "pppsync", .name = "pppsync",
.open = ppp_sync_open, .open = ppp_sync_open,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment