Commit 0f04d057 authored by Colin Ian King's avatar Colin Ian King Committed by David S. Miller

net: sched: cls_u32: use bitwise & rather than logical && on n->flags

Currently n->flags is being operated on by a logical && operator rather
than a bitwise & operator. This looks incorrect as these should be bit
flag operations. Fix this.

Detected by CoverityScan, CID#1460398 ("Logical vs. bitwise operator")

Fixes: 245dc512 ("net: sched: cls_u32: call block callbacks for offload")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 991a26af
...@@ -572,7 +572,7 @@ static int u32_replace_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n, ...@@ -572,7 +572,7 @@ static int u32_replace_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n,
n->flags |= TCA_CLS_FLAGS_IN_HW; n->flags |= TCA_CLS_FLAGS_IN_HW;
} }
if (skip_sw && !(n->flags && TCA_CLS_FLAGS_IN_HW)) if (skip_sw && !(n->flags & TCA_CLS_FLAGS_IN_HW))
return -EINVAL; return -EINVAL;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment