Commit 0f20d795 authored by Vitaly Kuznetsov's avatar Vitaly Kuznetsov Committed by David S. Miller

hv_netvsc: protect module refcount by checking net_device_ctx->vf_netdev

We're not guaranteed to see NETDEV_REGISTER/NETDEV_UNREGISTER notifications
only once per VF but we increase/decrease module refcount unconditionally.
Check vf_netdev to make sure we don't take/release it twice. We presume
that only one VF per netvsc device may exist.
Signed-off-by: default avatarVitaly Kuznetsov <vkuznets@redhat.com>
Acked-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 57c1826b
...@@ -1193,7 +1193,7 @@ static int netvsc_register_vf(struct net_device *vf_netdev) ...@@ -1193,7 +1193,7 @@ static int netvsc_register_vf(struct net_device *vf_netdev)
net_device_ctx = netdev_priv(ndev); net_device_ctx = netdev_priv(ndev);
netvsc_dev = net_device_ctx->nvdev; netvsc_dev = net_device_ctx->nvdev;
if (netvsc_dev == NULL) if (!netvsc_dev || net_device_ctx->vf_netdev)
return NOTIFY_DONE; return NOTIFY_DONE;
netdev_info(ndev, "VF registering: %s\n", vf_netdev->name); netdev_info(ndev, "VF registering: %s\n", vf_netdev->name);
...@@ -1312,7 +1312,7 @@ static int netvsc_unregister_vf(struct net_device *vf_netdev) ...@@ -1312,7 +1312,7 @@ static int netvsc_unregister_vf(struct net_device *vf_netdev)
net_device_ctx = netdev_priv(ndev); net_device_ctx = netdev_priv(ndev);
netvsc_dev = net_device_ctx->nvdev; netvsc_dev = net_device_ctx->nvdev;
if (netvsc_dev == NULL) if (!netvsc_dev || !net_device_ctx->vf_netdev)
return NOTIFY_DONE; return NOTIFY_DONE;
netdev_info(ndev, "VF unregistering: %s\n", vf_netdev->name); netdev_info(ndev, "VF unregistering: %s\n", vf_netdev->name);
netvsc_inject_disable(net_device_ctx); netvsc_inject_disable(net_device_ctx);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment