Commit 14d069d9 authored by Breno Leitao's avatar Breno Leitao Committed by Andi Shyti

i2c: tegra: Do not mark ACPI devices as irq safe

On ACPI machines, the tegra i2c module encounters an issue due to a
mutex being called inside a spinlock. This leads to the following bug:

	BUG: sleeping function called from invalid context at kernel/locking/mutex.c:585
	...

	Call trace:
	__might_sleep
	__mutex_lock_common
	mutex_lock_nested
	acpi_subsys_runtime_resume
	rpm_resume
	tegra_i2c_xfer

The problem arises because during __pm_runtime_resume(), the spinlock
&dev->power.lock is acquired before rpm_resume() is called. Later,
rpm_resume() invokes acpi_subsys_runtime_resume(), which relies on
mutexes, triggering the error.

To address this issue, devices on ACPI are now marked as not IRQ-safe,
considering the dependency of acpi_subsys_runtime_resume() on mutexes.

Fixes: bd2fdedb ("i2c: tegra: Add the ACPI support")
Cc: <stable@vger.kernel.org> # v5.17+
Co-developed-by: default avatarMichael van der Westhuizen <rmikey@meta.com>
Signed-off-by: default avatarMichael van der Westhuizen <rmikey@meta.com>
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarDmitry Osipenko <digetx@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Signed-off-by: default avatarAndi Shyti <andi.shyti@kernel.org>
parent 4e91fa1e
...@@ -1802,9 +1802,9 @@ static int tegra_i2c_probe(struct platform_device *pdev) ...@@ -1802,9 +1802,9 @@ static int tegra_i2c_probe(struct platform_device *pdev)
* domain. * domain.
* *
* VI I2C device shouldn't be marked as IRQ-safe because VI I2C won't * VI I2C device shouldn't be marked as IRQ-safe because VI I2C won't
* be used for atomic transfers. * be used for atomic transfers. ACPI device is not IRQ safe also.
*/ */
if (!IS_VI(i2c_dev)) if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev))
pm_runtime_irq_safe(i2c_dev->dev); pm_runtime_irq_safe(i2c_dev->dev);
pm_runtime_enable(i2c_dev->dev); pm_runtime_enable(i2c_dev->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment