Commit 15e9122d authored by james qian wang (Arm Technology China)'s avatar james qian wang (Arm Technology China) Committed by Liviu Dudau

drm/komeda: Mark the local functions as static

Fix the kbuild test rebot reported warnings:
- symbol was not declared. Should it be static?
- missing braces around initializer

Depends on:
- https://patchwork.freedesktop.org/series/58976/Reported-by: default avatarkbuild test robot <lkp@intel.com>
Signed-off-by: default avatarjames qian wang (Arm Technology China) <james.qian.wang@arm.com>
Signed-off-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
parent 8c919745
...@@ -391,7 +391,7 @@ static void d71_compiz_dump(struct komeda_component *c, struct seq_file *sf) ...@@ -391,7 +391,7 @@ static void d71_compiz_dump(struct komeda_component *c, struct seq_file *sf)
seq_printf(sf, "CU_USER_HIGH:\t\t0x%X\n", v[1]); seq_printf(sf, "CU_USER_HIGH:\t\t0x%X\n", v[1]);
} }
struct komeda_component_funcs d71_compiz_funcs = { static struct komeda_component_funcs d71_compiz_funcs = {
.update = d71_compiz_update, .update = d71_compiz_update,
.disable = d71_component_disable, .disable = d71_component_disable,
.dump_register = d71_compiz_dump, .dump_register = d71_compiz_dump,
...@@ -467,7 +467,7 @@ static void d71_improc_dump(struct komeda_component *c, struct seq_file *sf) ...@@ -467,7 +467,7 @@ static void d71_improc_dump(struct komeda_component *c, struct seq_file *sf)
seq_printf(sf, "IPS_RGB_YUV_COEFF%u:\t0x%X\n", i, v[i]); seq_printf(sf, "IPS_RGB_YUV_COEFF%u:\t0x%X\n", i, v[i]);
} }
struct komeda_component_funcs d71_improc_funcs = { static struct komeda_component_funcs d71_improc_funcs = {
.update = d71_improc_update, .update = d71_improc_update,
.disable = d71_component_disable, .disable = d71_component_disable,
.dump_register = d71_improc_dump, .dump_register = d71_improc_dump,
...@@ -543,7 +543,8 @@ static void d71_timing_ctrlr_update(struct komeda_component *c, ...@@ -543,7 +543,8 @@ static void d71_timing_ctrlr_update(struct komeda_component *c,
malidp_write32(reg, BLK_CONTROL, value); malidp_write32(reg, BLK_CONTROL, value);
} }
void d71_timing_ctrlr_dump(struct komeda_component *c, struct seq_file *sf) static void d71_timing_ctrlr_dump(struct komeda_component *c,
struct seq_file *sf)
{ {
u32 v[8], i; u32 v[8], i;
...@@ -579,7 +580,7 @@ void d71_timing_ctrlr_dump(struct komeda_component *c, struct seq_file *sf) ...@@ -579,7 +580,7 @@ void d71_timing_ctrlr_dump(struct komeda_component *c, struct seq_file *sf)
seq_printf(sf, "BS_USER:\t\t0x%X\n", v[4]); seq_printf(sf, "BS_USER:\t\t0x%X\n", v[4]);
} }
struct komeda_component_funcs d71_timing_ctrlr_funcs = { static struct komeda_component_funcs d71_timing_ctrlr_funcs = {
.update = d71_timing_ctrlr_update, .update = d71_timing_ctrlr_update,
.disable = d71_timing_ctrlr_disable, .disable = d71_timing_ctrlr_disable,
.dump_register = d71_timing_ctrlr_dump, .dump_register = d71_timing_ctrlr_dump,
......
...@@ -52,7 +52,7 @@ komeda_crtc_atomic_check(struct drm_crtc *crtc, ...@@ -52,7 +52,7 @@ komeda_crtc_atomic_check(struct drm_crtc *crtc,
return 0; return 0;
} }
u32 komeda_calc_mclk(struct komeda_crtc_state *kcrtc_st) static u32 komeda_calc_mclk(struct komeda_crtc_state *kcrtc_st)
{ {
unsigned long mclk = kcrtc_st->base.adjusted_mode.clock * 1000; unsigned long mclk = kcrtc_st->base.adjusted_mode.clock * 1000;
...@@ -350,7 +350,7 @@ static bool komeda_crtc_mode_fixup(struct drm_crtc *crtc, ...@@ -350,7 +350,7 @@ static bool komeda_crtc_mode_fixup(struct drm_crtc *crtc,
return true; return true;
} }
struct drm_crtc_helper_funcs komeda_crtc_helper_funcs = { static struct drm_crtc_helper_funcs komeda_crtc_helper_funcs = {
.atomic_check = komeda_crtc_atomic_check, .atomic_check = komeda_crtc_atomic_check,
.atomic_flush = komeda_crtc_atomic_flush, .atomic_flush = komeda_crtc_atomic_flush,
.atomic_enable = komeda_crtc_atomic_enable, .atomic_enable = komeda_crtc_atomic_enable,
......
...@@ -127,7 +127,7 @@ static const struct komeda_product_data komeda_products[] = { ...@@ -127,7 +127,7 @@ static const struct komeda_product_data komeda_products[] = {
}, },
}; };
const struct of_device_id komeda_of_match[] = { static const struct of_device_id komeda_of_match[] = {
{ .compatible = "arm,mali-d71", .data = &komeda_products[MALI_D71], }, { .compatible = "arm,mali-d71", .data = &komeda_products[MALI_D71], },
{}, {},
}; };
......
...@@ -62,7 +62,7 @@ void komeda_pipeline_destroy(struct komeda_dev *mdev, ...@@ -62,7 +62,7 @@ void komeda_pipeline_destroy(struct komeda_dev *mdev,
devm_kfree(mdev->dev, pipe); devm_kfree(mdev->dev, pipe);
} }
struct komeda_component ** static struct komeda_component **
komeda_pipeline_get_component_pos(struct komeda_pipeline *pipe, int id) komeda_pipeline_get_component_pos(struct komeda_pipeline *pipe, int id)
{ {
struct komeda_dev *mdev = pipe->mdev; struct komeda_dev *mdev = pipe->mdev;
......
...@@ -20,7 +20,7 @@ static inline bool is_switching_user(void *old, void *new) ...@@ -20,7 +20,7 @@ static inline bool is_switching_user(void *old, void *new)
return old != new; return old != new;
} }
struct komeda_pipeline_state * static struct komeda_pipeline_state *
komeda_pipeline_get_state(struct komeda_pipeline *pipe, komeda_pipeline_get_state(struct komeda_pipeline *pipe,
struct drm_atomic_state *state) struct drm_atomic_state *state)
{ {
...@@ -45,7 +45,7 @@ komeda_pipeline_get_old_state(struct komeda_pipeline *pipe, ...@@ -45,7 +45,7 @@ komeda_pipeline_get_old_state(struct komeda_pipeline *pipe,
return NULL; return NULL;
} }
struct komeda_pipeline_state * static struct komeda_pipeline_state *
komeda_pipeline_get_new_state(struct komeda_pipeline *pipe, komeda_pipeline_get_new_state(struct komeda_pipeline *pipe,
struct drm_atomic_state *state) struct drm_atomic_state *state)
{ {
...@@ -58,7 +58,7 @@ komeda_pipeline_get_new_state(struct komeda_pipeline *pipe, ...@@ -58,7 +58,7 @@ komeda_pipeline_get_new_state(struct komeda_pipeline *pipe,
} }
/* Assign pipeline for crtc */ /* Assign pipeline for crtc */
struct komeda_pipeline_state * static struct komeda_pipeline_state *
komeda_pipeline_get_state_and_set_crtc(struct komeda_pipeline *pipe, komeda_pipeline_get_state_and_set_crtc(struct komeda_pipeline *pipe,
struct drm_atomic_state *state, struct drm_atomic_state *state,
struct drm_crtc *crtc) struct drm_crtc *crtc)
...@@ -505,8 +505,9 @@ int komeda_build_display_data_flow(struct komeda_crtc *kcrtc, ...@@ -505,8 +505,9 @@ int komeda_build_display_data_flow(struct komeda_crtc *kcrtc,
return 0; return 0;
} }
void komeda_pipeline_unbound_components(struct komeda_pipeline *pipe, static void
struct komeda_pipeline_state *new) komeda_pipeline_unbound_components(struct komeda_pipeline *pipe,
struct komeda_pipeline_state *new)
{ {
struct drm_atomic_state *drm_st = new->obj.state; struct drm_atomic_state *drm_st = new->obj.state;
struct komeda_pipeline_state *old = priv_to_pipe_st(pipe->obj.state); struct komeda_pipeline_state *old = priv_to_pipe_st(pipe->obj.state);
......
...@@ -47,8 +47,9 @@ komeda_plane_init_data_flow(struct drm_plane_state *st, ...@@ -47,8 +47,9 @@ komeda_plane_init_data_flow(struct drm_plane_state *st,
* RETURNS: * RETURNS:
* Zero for success or -errno * Zero for success or -errno
*/ */
int komeda_plane_atomic_check(struct drm_plane *plane, static int
struct drm_plane_state *state) komeda_plane_atomic_check(struct drm_plane *plane,
struct drm_plane_state *state)
{ {
struct komeda_plane *kplane = to_kplane(plane); struct komeda_plane *kplane = to_kplane(plane);
struct komeda_plane_state *kplane_st = to_kplane_st(state); struct komeda_plane_state *kplane_st = to_kplane_st(state);
...@@ -87,8 +88,9 @@ int komeda_plane_atomic_check(struct drm_plane *plane, ...@@ -87,8 +88,9 @@ int komeda_plane_atomic_check(struct drm_plane *plane,
/* plane doesn't represent a real HW, so there is no HW update for plane. /* plane doesn't represent a real HW, so there is no HW update for plane.
* komeda handles all the HW update in crtc->atomic_flush * komeda handles all the HW update in crtc->atomic_flush
*/ */
void komeda_plane_atomic_update(struct drm_plane *plane, static void
struct drm_plane_state *old_state) komeda_plane_atomic_update(struct drm_plane *plane,
struct drm_plane_state *old_state)
{ {
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment