Commit 17323917 authored by Rodrigo Vivi's avatar Rodrigo Vivi

drm/xe: Remove useless mem_access on PAT dumps

PAT dumps are already protected by the xe_pm_runtime_{get,put}
around the debugfs call. So, these can be removed.
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240222163937.138342-14-rodrigo.vivi@intel.com
parent 23be0e6e
...@@ -174,7 +174,6 @@ static void xelp_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -174,7 +174,6 @@ static void xelp_dump(struct xe_gt *gt, struct drm_printer *p)
struct xe_device *xe = gt_to_xe(gt); struct xe_device *xe = gt_to_xe(gt);
int i, err; int i, err;
xe_device_mem_access_get(xe);
err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
if (err) if (err)
goto err_fw; goto err_fw;
...@@ -192,7 +191,6 @@ static void xelp_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -192,7 +191,6 @@ static void xelp_dump(struct xe_gt *gt, struct drm_printer *p)
err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
err_fw: err_fw:
xe_assert(xe, !err); xe_assert(xe, !err);
xe_device_mem_access_put(xe);
} }
static const struct xe_pat_ops xelp_pat_ops = { static const struct xe_pat_ops xelp_pat_ops = {
...@@ -205,7 +203,6 @@ static void xehp_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -205,7 +203,6 @@ static void xehp_dump(struct xe_gt *gt, struct drm_printer *p)
struct xe_device *xe = gt_to_xe(gt); struct xe_device *xe = gt_to_xe(gt);
int i, err; int i, err;
xe_device_mem_access_get(xe);
err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
if (err) if (err)
goto err_fw; goto err_fw;
...@@ -225,7 +222,6 @@ static void xehp_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -225,7 +222,6 @@ static void xehp_dump(struct xe_gt *gt, struct drm_printer *p)
err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
err_fw: err_fw:
xe_assert(xe, !err); xe_assert(xe, !err);
xe_device_mem_access_put(xe);
} }
static const struct xe_pat_ops xehp_pat_ops = { static const struct xe_pat_ops xehp_pat_ops = {
...@@ -238,7 +234,6 @@ static void xehpc_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -238,7 +234,6 @@ static void xehpc_dump(struct xe_gt *gt, struct drm_printer *p)
struct xe_device *xe = gt_to_xe(gt); struct xe_device *xe = gt_to_xe(gt);
int i, err; int i, err;
xe_device_mem_access_get(xe);
err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
if (err) if (err)
goto err_fw; goto err_fw;
...@@ -256,7 +251,6 @@ static void xehpc_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -256,7 +251,6 @@ static void xehpc_dump(struct xe_gt *gt, struct drm_printer *p)
err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
err_fw: err_fw:
xe_assert(xe, !err); xe_assert(xe, !err);
xe_device_mem_access_put(xe);
} }
static const struct xe_pat_ops xehpc_pat_ops = { static const struct xe_pat_ops xehpc_pat_ops = {
...@@ -269,7 +263,6 @@ static void xelpg_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -269,7 +263,6 @@ static void xelpg_dump(struct xe_gt *gt, struct drm_printer *p)
struct xe_device *xe = gt_to_xe(gt); struct xe_device *xe = gt_to_xe(gt);
int i, err; int i, err;
xe_device_mem_access_get(xe);
err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
if (err) if (err)
goto err_fw; goto err_fw;
...@@ -292,7 +285,6 @@ static void xelpg_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -292,7 +285,6 @@ static void xelpg_dump(struct xe_gt *gt, struct drm_printer *p)
err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
err_fw: err_fw:
xe_assert(xe, !err); xe_assert(xe, !err);
xe_device_mem_access_put(xe);
} }
/* /*
...@@ -325,7 +317,6 @@ static void xe2_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -325,7 +317,6 @@ static void xe2_dump(struct xe_gt *gt, struct drm_printer *p)
int i, err; int i, err;
u32 pat; u32 pat;
xe_device_mem_access_get(xe);
err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
if (err) if (err)
goto err_fw; goto err_fw;
...@@ -370,7 +361,6 @@ static void xe2_dump(struct xe_gt *gt, struct drm_printer *p) ...@@ -370,7 +361,6 @@ static void xe2_dump(struct xe_gt *gt, struct drm_printer *p)
err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT); err = xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
err_fw: err_fw:
xe_assert(xe, !err); xe_assert(xe, !err);
xe_device_mem_access_put(xe);
} }
static const struct xe_pat_ops xe2_pat_ops = { static const struct xe_pat_ops xe2_pat_ops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment