Commit 18d777cd authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman

greybus: svc: No need of a separate version request

SVC already provided version to the AP on version-request, no need to
ask for that again. Drop it.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent ead35460
...@@ -11,9 +11,6 @@ ...@@ -11,9 +11,6 @@
static struct ida greybus_svc_device_id_map; static struct ida greybus_svc_device_id_map;
/* Define get_version() routine */
define_get_version(gb_svc, SVC);
/* /*
* AP's SVC cport is required early to get messages from the SVC. This happens * AP's SVC cport is required early to get messages from the SVC. This happens
* even before the Endo is created and hence any modules or interfaces. * even before the Endo is created and hence any modules or interfaces.
...@@ -390,19 +387,9 @@ static int gb_svc_request_recv(u8 type, struct gb_operation *op) ...@@ -390,19 +387,9 @@ static int gb_svc_request_recv(u8 type, struct gb_operation *op)
} }
} }
/*
* Do initial setup of the SVC.
*/
static int gb_svc_device_setup(struct gb_svc *gb_svc)
{
/* First thing we need to do is check the version */
return get_version(gb_svc);
}
static int gb_svc_connection_init(struct gb_connection *connection) static int gb_svc_connection_init(struct gb_connection *connection)
{ {
struct gb_svc *svc; struct gb_svc *svc;
int ret;
svc = kzalloc(sizeof(*svc), GFP_KERNEL); svc = kzalloc(sizeof(*svc), GFP_KERNEL);
if (!svc) if (!svc)
...@@ -426,14 +413,10 @@ static int gb_svc_connection_init(struct gb_connection *connection) ...@@ -426,14 +413,10 @@ static int gb_svc_connection_init(struct gb_connection *connection)
ida_init(&greybus_svc_device_id_map); ida_init(&greybus_svc_device_id_map);
ret = gb_svc_device_setup(svc);
if (ret)
kfree(svc);
/* Set interface's svc connection */ /* Set interface's svc connection */
connection->bundle->intf->svc = svc; connection->bundle->intf->svc = svc;
return ret; return 0;
} }
static void gb_svc_connection_exit(struct gb_connection *connection) static void gb_svc_connection_exit(struct gb_connection *connection)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment