Commit 1a8b18af authored by Fabien Dessenne's avatar Fabien Dessenne Committed by Mauro Carvalho Chehab

[media] bdisp: remove needless check

As reported by smatch:
	drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection() warn: unsigned 'out.width' is never less than zero.
	drivers/media/platform/sti/bdisp/bdisp-v4l2.c:947 bdisp_s_selection() warn: unsigned 'out.height' is never less than zero.
Indeed, width and height are unsigned.
Signed-off-by: default avatarFabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 87b09bd0
...@@ -944,8 +944,7 @@ static int bdisp_s_selection(struct file *file, void *fh, ...@@ -944,8 +944,7 @@ static int bdisp_s_selection(struct file *file, void *fh,
out.width = ALIGN(in->width, frame->fmt->w_align); out.width = ALIGN(in->width, frame->fmt->w_align);
out.height = ALIGN(in->height, frame->fmt->w_align); out.height = ALIGN(in->height, frame->fmt->w_align);
if ((out.width < 0) || (out.height < 0) || if (((out.left + out.width) > frame->width) ||
((out.left + out.width) > frame->width) ||
((out.top + out.height) > frame->height)) { ((out.top + out.height) > frame->height)) {
dev_err(ctx->bdisp_dev->dev, dev_err(ctx->bdisp_dev->dev,
"Invalid crop: %dx%d@(%d,%d) vs frame: %dx%d\n", "Invalid crop: %dx%d@(%d,%d) vs frame: %dx%d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment