Commit 1af95de6 authored by Wang YanQing's avatar Wang YanQing Committed by Al Viro

fs:super:get_anon_bdev: fix race condition could cause dev exceed its upper limitation

Execution of get_anon_bdev concurrently and preemptive kernel all
could bring race condition, it isn't enough to check dev against
its upper limitation with equality operator only.

This patch fix it.
Signed-off-by: default avatarWang YanQing <udknight@gmail.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 2adc376c
...@@ -842,7 +842,7 @@ int get_anon_bdev(dev_t *p) ...@@ -842,7 +842,7 @@ int get_anon_bdev(dev_t *p)
else if (error) else if (error)
return -EAGAIN; return -EAGAIN;
if (dev == (1 << MINORBITS)) { if (dev >= (1 << MINORBITS)) {
spin_lock(&unnamed_dev_lock); spin_lock(&unnamed_dev_lock);
ida_remove(&unnamed_dev_ida, dev); ida_remove(&unnamed_dev_ida, dev);
if (unnamed_dev_start > dev) if (unnamed_dev_start > dev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment