Commit 1bf08313 authored by Guo Zhengkui's avatar Guo Zhengkui Committed by Andrew Morton

userfaultfd/selftests: use swap() instead of open coding it

Address the following coccicheck warning:

tools/testing/selftests/vm/userfaultfd.c:1536:21-22: WARNING opportunity
for swap().
tools/testing/selftests/vm/userfaultfd.c:1540:33-34: WARNING opportunity
for swap().

by using swap() for the swapping of variable values and drop
`tmp_area` that is not needed any more.

`swap()` macro in userfaultfd.c is introduced in commit 68169686
("selftests: vm: remove dependecy from internal kernel macros")

It has been tested with gcc (Debian 8.3.0-6) 8.3.0.

Link: https://lkml.kernel.org/r/20220407123141.4998-1-guozhengkui@vivo.comSigned-off-by: default avatarGuo Zhengkui <guozhengkui@vivo.com>
Reviewed-by: default avatarMuchun Song <songmuchun@bytedance.com>
Reviewed-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent c0eeeb02
...@@ -1422,7 +1422,6 @@ static void userfaultfd_pagemap_test(unsigned int test_pgsize) ...@@ -1422,7 +1422,6 @@ static void userfaultfd_pagemap_test(unsigned int test_pgsize)
static int userfaultfd_stress(void) static int userfaultfd_stress(void)
{ {
void *area; void *area;
char *tmp_area;
unsigned long nr; unsigned long nr;
struct uffdio_register uffdio_register; struct uffdio_register uffdio_register;
struct uffd_stats uffd_stats[nr_cpus]; struct uffd_stats uffd_stats[nr_cpus];
...@@ -1533,13 +1532,9 @@ static int userfaultfd_stress(void) ...@@ -1533,13 +1532,9 @@ static int userfaultfd_stress(void)
count_verify[nr], nr); count_verify[nr], nr);
/* prepare next bounce */ /* prepare next bounce */
tmp_area = area_src; swap(area_src, area_dst);
area_src = area_dst;
area_dst = tmp_area;
tmp_area = area_src_alias; swap(area_src_alias, area_dst_alias);
area_src_alias = area_dst_alias;
area_dst_alias = tmp_area;
uffd_stats_report(uffd_stats, nr_cpus); uffd_stats_report(uffd_stats, nr_cpus);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment