Commit 1d6ba284 authored by Maxime COQUELIN's avatar Maxime COQUELIN Committed by Greg Kroah-Hartman

serial: st-asc: Fix overflow in baudrate calculation

In the current calculation, if the required baud rate is above 262143,
we get an overflow.

This patch uses a 64bits variable to do the maths.
Also, we remove the '+1' to avoid a divide by zero if the input clock
rate is something unexpected.
Indeed, if the input clock rate is zero, it is preferable to be notified,
since the UART won't work anyway.
Signed-off-by: default avatarMaxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5b4e79ae
......@@ -527,12 +527,12 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios,
* ASCBaudRate = ------------------------
* inputclock
*
* However to keep the maths inside 32bits we divide top and
* bottom by 64. The +1 is to avoid a divide by zero if the
* input clock rate is something unexpected.
* To keep maths inside 64bits, we divide inputclock by 16.
*/
u32 counter = (baud * 16384) / ((port->uartclk / 64) + 1);
asc_out(port, ASC_BAUDRATE, counter);
u64 dividend = (u64)baud * (1 << 16);
do_div(dividend, port->uartclk / 16);
asc_out(port, ASC_BAUDRATE, dividend);
ctrl_val |= ASC_CTL_BAUDMODE;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment