Commit 22a9835c authored by Dave Hansen's avatar Dave Hansen Committed by Linus Torvalds

[PATCH] unify PFN_* macros

Just about every architecture defines some macros to do operations on pfns.
 They're all virtually identical.  This patch consolidates all of them.

One minor glitch is that at least i386 uses them in a very skeletal header
file.  To keep away from #include dependency hell, I stuck the new
definitions in a new, isolated header.

Of all of the implementations, sh64 is the only one that varied by a bit.
It used some masks to ensure that any sign-extension got ripped away before
the arithmetic is done.  This has been posted to that sh64 maintainers and
the development list.

Compiles on x86, x86_64, ia64 and ppc64.
Signed-off-by: default avatarDave Hansen <haveblue@us.ibm.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 95144c78
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#include <linux/root_dev.h> #include <linux/root_dev.h>
#include <linux/initrd.h> #include <linux/initrd.h>
#include <linux/eisa.h> #include <linux/eisa.h>
#include <linux/pfn.h>
#ifdef CONFIG_MAGIC_SYSRQ #ifdef CONFIG_MAGIC_SYSRQ
#include <linux/sysrq.h> #include <linux/sysrq.h>
#include <linux/reboot.h> #include <linux/reboot.h>
...@@ -241,9 +242,6 @@ reserve_std_resources(void) ...@@ -241,9 +242,6 @@ reserve_std_resources(void)
request_resource(io, standard_io_resources+i); request_resource(io, standard_io_resources+i);
} }
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
#define PFN_MAX PFN_DOWN(0x80000000) #define PFN_MAX PFN_DOWN(0x80000000)
#define for_each_mem_cluster(memdesc, cluster, i) \ #define for_each_mem_cluster(memdesc, cluster, i) \
for ((cluster) = (memdesc)->cluster, (i) = 0; \ for ((cluster) = (memdesc)->cluster, (i) = 0; \
...@@ -472,11 +470,6 @@ page_is_ram(unsigned long pfn) ...@@ -472,11 +470,6 @@ page_is_ram(unsigned long pfn)
return 0; return 0;
} }
#undef PFN_UP
#undef PFN_DOWN
#undef PFN_PHYS
#undef PFN_MAX
void __init void __init
setup_arch(char **cmdline_p) setup_arch(char **cmdline_p)
{ {
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/bootmem.h> #include <linux/bootmem.h>
#include <linux/swap.h> #include <linux/swap.h>
#include <linux/initrd.h> #include <linux/initrd.h>
#include <linux/pfn.h>
#include <asm/hwrpb.h> #include <asm/hwrpb.h>
#include <asm/pgalloc.h> #include <asm/pgalloc.h>
...@@ -27,9 +28,6 @@ bootmem_data_t node_bdata[MAX_NUMNODES]; ...@@ -27,9 +28,6 @@ bootmem_data_t node_bdata[MAX_NUMNODES];
#define DBGDCONT(args...) #define DBGDCONT(args...)
#endif #endif
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
#define for_each_mem_cluster(memdesc, cluster, i) \ #define for_each_mem_cluster(memdesc, cluster, i) \
for ((cluster) = (memdesc)->cluster, (i) = 0; \ for ((cluster) = (memdesc)->cluster, (i) = 0; \
(i) < (memdesc)->numclusters; (i)++, (cluster)++) (i) < (memdesc)->numclusters; (i)++, (cluster)++)
......
...@@ -23,6 +23,7 @@ ...@@ -23,6 +23,7 @@
#include <linux/initrd.h> #include <linux/initrd.h>
#include <linux/bootmem.h> #include <linux/bootmem.h>
#include <linux/blkdev.h> #include <linux/blkdev.h>
#include <linux/pfn.h>
#include <asm/segment.h> #include <asm/segment.h>
#include <asm/mach-types.h> #include <asm/mach-types.h>
...@@ -101,12 +102,6 @@ struct node_info { ...@@ -101,12 +102,6 @@ struct node_info {
int bootmap_pages; int bootmap_pages;
}; };
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_UP(x) (PAGE_ALIGN(x) >> PAGE_SHIFT)
#define PFN_SIZE(x) ((x) >> PAGE_SHIFT)
#define PFN_RANGE(s,e) PFN_SIZE(PAGE_ALIGN((unsigned long)(e)) - \
(((unsigned long)(s)) & PAGE_MASK))
/* /*
* FIXME: We really want to avoid allocating the bootmap bitmap * FIXME: We really want to avoid allocating the bootmap bitmap
* over the top of the initrd. Hopefully, this is located towards * over the top of the initrd. Hopefully, this is located towards
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
#include <linux/seq_file.h> #include <linux/seq_file.h>
#include <linux/tty.h> #include <linux/tty.h>
#include <linux/utsname.h> #include <linux/utsname.h>
#include <linux/pfn.h>
#include <asm/setup.h> #include <asm/setup.h>
...@@ -88,10 +89,6 @@ setup_arch(char **cmdline_p) ...@@ -88,10 +89,6 @@ setup_arch(char **cmdline_p)
init_mm.end_data = (unsigned long) &_edata; init_mm.end_data = (unsigned long) &_edata;
init_mm.brk = (unsigned long) &_end; init_mm.brk = (unsigned long) &_end;
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
/* min_low_pfn points to the start of DRAM, start_pfn points /* min_low_pfn points to the start of DRAM, start_pfn points
* to the first DRAM pages after the kernel, and max_low_pfn * to the first DRAM pages after the kernel, and max_low_pfn
* to the end of DRAM. * to the end of DRAM.
......
...@@ -46,6 +46,7 @@ ...@@ -46,6 +46,7 @@
#include <linux/kexec.h> #include <linux/kexec.h>
#include <linux/crash_dump.h> #include <linux/crash_dump.h>
#include <linux/dmi.h> #include <linux/dmi.h>
#include <linux/pfn.h>
#include <video/edid.h> #include <video/edid.h>
......
...@@ -31,6 +31,7 @@ ...@@ -31,6 +31,7 @@
#include <linux/nodemask.h> #include <linux/nodemask.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/kexec.h> #include <linux/kexec.h>
#include <linux/pfn.h>
#include <asm/e820.h> #include <asm/e820.h>
#include <asm/setup.h> #include <asm/setup.h>
......
...@@ -24,6 +24,7 @@ ...@@ -24,6 +24,7 @@
#include <linux/tty.h> #include <linux/tty.h>
#include <linux/cpu.h> #include <linux/cpu.h>
#include <linux/nodemask.h> #include <linux/nodemask.h>
#include <linux/pfn.h>
#include <asm/processor.h> #include <asm/processor.h>
#include <asm/pgtable.h> #include <asm/pgtable.h>
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/initrd.h> #include <linux/initrd.h>
#include <linux/nodemask.h> #include <linux/nodemask.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/pfn.h>
#include <asm/setup.h> #include <asm/setup.h>
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
#include <linux/highmem.h> #include <linux/highmem.h>
#include <linux/bitops.h> #include <linux/bitops.h>
#include <linux/nodemask.h> #include <linux/nodemask.h>
#include <linux/pfn.h>
#include <asm/types.h> #include <asm/types.h>
#include <asm/processor.h> #include <asm/processor.h>
#include <asm/page.h> #include <asm/page.h>
......
...@@ -45,9 +45,6 @@ extern void __init prom_init_cmdline(void); ...@@ -45,9 +45,6 @@ extern void __init prom_init_cmdline(void);
extern unsigned long __init prom_get_memsize(void); extern unsigned long __init prom_get_memsize(void);
extern void __init it8172_init_ram_resource(unsigned long memsize); extern void __init it8172_init_ram_resource(unsigned long memsize);
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_ALIGN(x) (((unsigned long)(x) + (PAGE_SIZE - 1)) & PAGE_MASK)
const char *get_system_type(void) const char *get_system_type(void)
{ {
return "Globespan IVR"; return "Globespan IVR";
......
...@@ -45,9 +45,6 @@ extern void __init prom_init_cmdline(void); ...@@ -45,9 +45,6 @@ extern void __init prom_init_cmdline(void);
extern unsigned long __init prom_get_memsize(void); extern unsigned long __init prom_get_memsize(void);
extern void __init it8172_init_ram_resource(unsigned long memsize); extern void __init it8172_init_ram_resource(unsigned long memsize);
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_ALIGN(x) (((unsigned long)(x) + (PAGE_SIZE - 1)) & PAGE_MASK)
const char *get_system_type(void) const char *get_system_type(void)
{ {
return "ITE QED-4N-S01B"; return "ITE QED-4N-S01B";
......
...@@ -34,6 +34,7 @@ ...@@ -34,6 +34,7 @@
#include <linux/highmem.h> #include <linux/highmem.h>
#include <linux/console.h> #include <linux/console.h>
#include <linux/mmzone.h> #include <linux/mmzone.h>
#include <linux/pfn.h>
#include <asm/addrspace.h> #include <asm/addrspace.h>
#include <asm/bootinfo.h> #include <asm/bootinfo.h>
...@@ -257,10 +258,6 @@ static inline int parse_rd_cmdline(unsigned long* rd_start, unsigned long* rd_en ...@@ -257,10 +258,6 @@ static inline int parse_rd_cmdline(unsigned long* rd_start, unsigned long* rd_en
return 0; return 0;
} }
#define PFN_UP(x) (((x) + PAGE_SIZE - 1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
#define MAXMEM HIGHMEM_START #define MAXMEM HIGHMEM_START
#define MAXMEM_PFN PFN_DOWN(MAXMEM) #define MAXMEM_PFN PFN_DOWN(MAXMEM)
...@@ -493,10 +490,6 @@ static inline void resource_init(void) ...@@ -493,10 +490,6 @@ static inline void resource_init(void)
} }
} }
#undef PFN_UP
#undef PFN_DOWN
#undef PFN_PHYS
#undef MAXMEM #undef MAXMEM
#undef MAXMEM_PFN #undef MAXMEM_PFN
......
...@@ -49,9 +49,6 @@ static char *mtypes[3] = { ...@@ -49,9 +49,6 @@ static char *mtypes[3] = {
/* References to section boundaries */ /* References to section boundaries */
extern char _end; extern char _end;
#define PFN_ALIGN(x) (((unsigned long)(x) + (PAGE_SIZE - 1)) & PAGE_MASK)
struct prom_pmemblock * __init prom_getmdesc(void) struct prom_pmemblock * __init prom_getmdesc(void)
{ {
char *memsize_str; char *memsize_str;
...@@ -109,10 +106,10 @@ struct prom_pmemblock * __init prom_getmdesc(void) ...@@ -109,10 +106,10 @@ struct prom_pmemblock * __init prom_getmdesc(void)
mdesc[3].type = yamon_dontuse; mdesc[3].type = yamon_dontuse;
mdesc[3].base = 0x00100000; mdesc[3].base = 0x00100000;
mdesc[3].size = CPHYSADDR(PFN_ALIGN(&_end)) - mdesc[3].base; mdesc[3].size = CPHYSADDR(PAGE_ALIGN(&_end)) - mdesc[3].base;
mdesc[4].type = yamon_free; mdesc[4].type = yamon_free;
mdesc[4].base = CPHYSADDR(PFN_ALIGN(&_end)); mdesc[4].base = CPHYSADDR(PAGE_ALIGN(&_end));
mdesc[4].size = memsize - mdesc[4].base; mdesc[4].size = memsize - mdesc[4].base;
return &mdesc[0]; return &mdesc[0];
......
...@@ -42,9 +42,6 @@ static char *mtypes[3] = { ...@@ -42,9 +42,6 @@ static char *mtypes[3] = {
/* References to section boundaries */ /* References to section boundaries */
extern char _end; extern char _end;
#define PFN_ALIGN(x) (((unsigned long)(x) + (PAGE_SIZE - 1)) & PAGE_MASK)
struct prom_pmemblock * __init prom_getmdesc(void) struct prom_pmemblock * __init prom_getmdesc(void)
{ {
unsigned int memsize; unsigned int memsize;
...@@ -64,10 +61,10 @@ struct prom_pmemblock * __init prom_getmdesc(void) ...@@ -64,10 +61,10 @@ struct prom_pmemblock * __init prom_getmdesc(void)
mdesc[2].type = simmem_reserved; mdesc[2].type = simmem_reserved;
mdesc[2].base = 0x00100000; mdesc[2].base = 0x00100000;
mdesc[2].size = CPHYSADDR(PFN_ALIGN(&_end)) - mdesc[2].base; mdesc[2].size = CPHYSADDR(PAGE_ALIGN(&_end)) - mdesc[2].base;
mdesc[3].type = simmem_free; mdesc[3].type = simmem_free;
mdesc[3].base = CPHYSADDR(PFN_ALIGN(&_end)); mdesc[3].base = CPHYSADDR(PAGE_ALIGN(&_end));
mdesc[3].size = memsize - mdesc[3].base; mdesc[3].size = memsize - mdesc[3].base;
return &mdesc[0]; return &mdesc[0];
......
...@@ -25,6 +25,7 @@ ...@@ -25,6 +25,7 @@
#include <linux/highmem.h> #include <linux/highmem.h>
#include <linux/swap.h> #include <linux/swap.h>
#include <linux/proc_fs.h> #include <linux/proc_fs.h>
#include <linux/pfn.h>
#include <asm/bootinfo.h> #include <asm/bootinfo.h>
#include <asm/cachectl.h> #include <asm/cachectl.h>
...@@ -177,9 +178,6 @@ void __init paging_init(void) ...@@ -177,9 +178,6 @@ void __init paging_init(void)
free_area_init(zones_size); free_area_init(zones_size);
} }
#define PFN_UP(x) (((x) + PAGE_SIZE - 1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
static inline int page_is_ram(unsigned long pagenr) static inline int page_is_ram(unsigned long pagenr)
{ {
int i; int i;
......
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
#include <linux/nodemask.h> #include <linux/nodemask.h>
#include <linux/swap.h> #include <linux/swap.h>
#include <linux/bootmem.h> #include <linux/bootmem.h>
#include <linux/pfn.h>
#include <asm/page.h> #include <asm/page.h>
#include <asm/sections.h> #include <asm/sections.h>
...@@ -28,8 +29,6 @@ ...@@ -28,8 +29,6 @@
#include <asm/sn/sn_private.h> #include <asm/sn/sn_private.h>
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define SLOT_PFNSHIFT (SLOT_SHIFT - PAGE_SHIFT) #define SLOT_PFNSHIFT (SLOT_SHIFT - PAGE_SHIFT)
#define PFN_NASIDSHFT (NASID_SHFT - PAGE_SHIFT) #define PFN_NASIDSHFT (NASID_SHFT - PAGE_SHIFT)
......
...@@ -20,6 +20,7 @@ ...@@ -20,6 +20,7 @@
#include <linux/root_dev.h> #include <linux/root_dev.h>
#include <linux/utsname.h> #include <linux/utsname.h>
#include <linux/cpu.h> #include <linux/cpu.h>
#include <linux/pfn.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
#include <asm/io.h> #include <asm/io.h>
#include <asm/sections.h> #include <asm/sections.h>
...@@ -275,10 +276,6 @@ void __init setup_arch(char **cmdline_p) ...@@ -275,10 +276,6 @@ void __init setup_arch(char **cmdline_p)
sh_mv_setup(cmdline_p); sh_mv_setup(cmdline_p);
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
/* /*
* Find the highest page frame number we have available * Find the highest page frame number we have available
*/ */
......
...@@ -48,6 +48,7 @@ ...@@ -48,6 +48,7 @@
#include <linux/root_dev.h> #include <linux/root_dev.h>
#include <linux/cpu.h> #include <linux/cpu.h>
#include <linux/initrd.h> #include <linux/initrd.h>
#include <linux/pfn.h>
#include <asm/processor.h> #include <asm/processor.h>
#include <asm/page.h> #include <asm/page.h>
#include <asm/pgtable.h> #include <asm/pgtable.h>
......
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include "linux/vmalloc.h" #include "linux/vmalloc.h"
#include "linux/bootmem.h" #include "linux/bootmem.h"
#include "linux/module.h" #include "linux/module.h"
#include "linux/pfn.h"
#include "asm/types.h" #include "asm/types.h"
#include "asm/pgtable.h" #include "asm/pgtable.h"
#include "kern_util.h" #include "kern_util.h"
...@@ -316,8 +317,6 @@ void map_memory(unsigned long virt, unsigned long phys, unsigned long len, ...@@ -316,8 +317,6 @@ void map_memory(unsigned long virt, unsigned long phys, unsigned long len,
} }
} }
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
extern int __syscall_stub_start, __binary_start; extern int __syscall_stub_start, __binary_start;
void setup_physmem(unsigned long start, unsigned long reserve_end, void setup_physmem(unsigned long start, unsigned long reserve_end,
......
...@@ -6,9 +6,7 @@ ...@@ -6,9 +6,7 @@
#ifndef _i386_SETUP_H #ifndef _i386_SETUP_H
#define _i386_SETUP_H #define _i386_SETUP_H
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT) #include <linux/pfn.h>
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
/* /*
* Reserved space for vmalloc and iomap - defined in asm/page.h * Reserved space for vmalloc and iomap - defined in asm/page.h
......
...@@ -24,10 +24,6 @@ ...@@ -24,10 +24,6 @@
#define RAMDISK_PROMPT_FLAG (0x8000) #define RAMDISK_PROMPT_FLAG (0x8000)
#define RAMDISK_LOAD_FLAG (0x4000) #define RAMDISK_LOAD_FLAG (0x4000)
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
extern unsigned long memory_start; extern unsigned long memory_start;
extern unsigned long memory_end; extern unsigned long memory_end;
...@@ -61,9 +61,4 @@ extern int platform_int_priority[NR_INTC_IRQS]; ...@@ -61,9 +61,4 @@ extern int platform_int_priority[NR_INTC_IRQS];
#define code_resource (platform_parms.kram_res_p[STANDARD_KRAM_RESOURCES - 2]) #define code_resource (platform_parms.kram_res_p[STANDARD_KRAM_RESOURCES - 2])
#define data_resource (platform_parms.kram_res_p[STANDARD_KRAM_RESOURCES - 1]) #define data_resource (platform_parms.kram_res_p[STANDARD_KRAM_RESOURCES - 1])
/* Be prepared to 64-bit sign extensions */
#define PFN_UP(x) ((((x) + PAGE_SIZE-1) >> PAGE_SHIFT) & 0x000fffff)
#define PFN_DOWN(x) (((x) >> PAGE_SHIFT) & 0x000fffff)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
#endif /* __ASM_SH64_PLATFORM_H */ #endif /* __ASM_SH64_PLATFORM_H */
#ifndef _LINUX_PFN_H_
#define _LINUX_PFN_H_
#define PFN_ALIGN(x) (((unsigned long)(x) + (PAGE_SIZE - 1)) & PAGE_MASK)
#define PFN_UP(x) (((x) + PAGE_SIZE-1) >> PAGE_SHIFT)
#define PFN_DOWN(x) ((x) >> PAGE_SHIFT)
#define PFN_PHYS(x) ((x) << PAGE_SHIFT)
#endif
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment