Commit 22bbd21b authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij

pinctrl: baytrail: fix some error handling in debugfs

We need to unlock before continuing.  Also the continue was accidentally
left out on one error path which would lead to a NULL dereference.

Fixes: 86e3ef81 ('pinctrl: baytrail: Update gpio chip operations')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent b5aa1006
...@@ -1390,6 +1390,7 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) ...@@ -1390,6 +1390,7 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
seq_printf(s, seq_printf(s,
"Could not retrieve pin %i conf0 reg\n", "Could not retrieve pin %i conf0 reg\n",
pin); pin);
raw_spin_unlock_irqrestore(&vg->lock, flags);
continue; continue;
} }
conf0 = readl(reg); conf0 = readl(reg);
...@@ -1398,6 +1399,8 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) ...@@ -1398,6 +1399,8 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
if (!reg) { if (!reg) {
seq_printf(s, seq_printf(s,
"Could not retrieve pin %i val reg\n", pin); "Could not retrieve pin %i val reg\n", pin);
raw_spin_unlock_irqrestore(&vg->lock, flags);
continue;
} }
val = readl(reg); val = readl(reg);
raw_spin_unlock_irqrestore(&vg->lock, flags); raw_spin_unlock_irqrestore(&vg->lock, flags);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment