Commit 235a251a authored by Max Schwarz's avatar Max Schwarz Committed by David S. Miller

arc_emac: write initial MAC address from devicetree to hw

The MAC address retrieved from dt was not actually written to the
hardware. This meant proper communication was only possible after
changing the MAC address.

Fix that by always writing the mac address during probing.
Signed-off-by: default avatarMax Schwarz <max.schwarz@online.de>
Acked-by: default avatarHeiko Stuebner <heiko@sntech.de>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 78541c1d
...@@ -574,6 +574,18 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev) ...@@ -574,6 +574,18 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev)
return NETDEV_TX_OK; return NETDEV_TX_OK;
} }
static void arc_emac_set_address_internal(struct net_device *ndev)
{
struct arc_emac_priv *priv = netdev_priv(ndev);
unsigned int addr_low, addr_hi;
addr_low = le32_to_cpu(*(__le32 *) &ndev->dev_addr[0]);
addr_hi = le16_to_cpu(*(__le16 *) &ndev->dev_addr[4]);
arc_reg_set(priv, R_ADDRL, addr_low);
arc_reg_set(priv, R_ADDRH, addr_hi);
}
/** /**
* arc_emac_set_address - Set the MAC address for this device. * arc_emac_set_address - Set the MAC address for this device.
* @ndev: Pointer to net_device structure. * @ndev: Pointer to net_device structure.
...@@ -587,9 +599,7 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev) ...@@ -587,9 +599,7 @@ static int arc_emac_tx(struct sk_buff *skb, struct net_device *ndev)
*/ */
static int arc_emac_set_address(struct net_device *ndev, void *p) static int arc_emac_set_address(struct net_device *ndev, void *p)
{ {
struct arc_emac_priv *priv = netdev_priv(ndev);
struct sockaddr *addr = p; struct sockaddr *addr = p;
unsigned int addr_low, addr_hi;
if (netif_running(ndev)) if (netif_running(ndev))
return -EBUSY; return -EBUSY;
...@@ -599,11 +609,7 @@ static int arc_emac_set_address(struct net_device *ndev, void *p) ...@@ -599,11 +609,7 @@ static int arc_emac_set_address(struct net_device *ndev, void *p)
memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len); memcpy(ndev->dev_addr, addr->sa_data, ndev->addr_len);
addr_low = le32_to_cpu(*(__le32 *) &ndev->dev_addr[0]); arc_emac_set_address_internal(ndev);
addr_hi = le16_to_cpu(*(__le16 *) &ndev->dev_addr[4]);
arc_reg_set(priv, R_ADDRL, addr_low);
arc_reg_set(priv, R_ADDRH, addr_hi);
return 0; return 0;
} }
...@@ -713,6 +719,7 @@ static int arc_emac_probe(struct platform_device *pdev) ...@@ -713,6 +719,7 @@ static int arc_emac_probe(struct platform_device *pdev)
else else
eth_hw_addr_random(ndev); eth_hw_addr_random(ndev);
arc_emac_set_address_internal(ndev);
dev_info(&pdev->dev, "MAC address is now %pM\n", ndev->dev_addr); dev_info(&pdev->dev, "MAC address is now %pM\n", ndev->dev_addr);
/* Do 1 allocation instead of 2 separate ones for Rx and Tx BD rings */ /* Do 1 allocation instead of 2 separate ones for Rx and Tx BD rings */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment