Commit 23feefda authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman

usb: iowarrior: replace kmalloc with kmalloc_array

A common flaw in the kernel is integer overflow during memory allocation
size calculations. In an effort to reduce the frequency of these bugs,
kmalloc_array was implemented, which allocates memory for an array,
while at the same time detects integer overflow.

This patch replaces cases of:

	kmalloc(a * b, gfp)

with:
	kmalloc_array(a, b, gfp)
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 87f88dfc
...@@ -808,8 +808,8 @@ static int iowarrior_probe(struct usb_interface *interface, ...@@ -808,8 +808,8 @@ static int iowarrior_probe(struct usb_interface *interface,
dev->int_in_endpoint->bInterval); dev->int_in_endpoint->bInterval);
/* create an internal buffer for interrupt data from the device */ /* create an internal buffer for interrupt data from the device */
dev->read_queue = dev->read_queue =
kmalloc(((dev->report_size + 1) * MAX_INTERRUPT_BUFFER), kmalloc_array(dev->report_size + 1, MAX_INTERRUPT_BUFFER,
GFP_KERNEL); GFP_KERNEL);
if (!dev->read_queue) if (!dev->read_queue)
goto error; goto error;
/* Get the serial-number of the chip */ /* Get the serial-number of the chip */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment