Commit 248ba8ec authored by Linus Lüssing's avatar Linus Lüssing Committed by David S. Miller

bridge: don't try to update timers in case of broken MLD queries

Currently we are reading an uninitialized value for the max_delay
variable when snooping an MLD query message of invalid length and would
update our timers with that.

Fixing this by simply ignoring such broken MLD queries (just like we do
for IGMP already).

This is a regression introduced by:
"bridge: disable snooping if there is no querier" (b00589af)
Reported-by: default avatarPaul Bolle <pebolle@tiscali.nl>
Signed-off-by: default avatarLinus Lüssing <linus.luessing@web.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent aab515d7
...@@ -1195,7 +1195,7 @@ static int br_ip6_multicast_query(struct net_bridge *br, ...@@ -1195,7 +1195,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
max_delay = msecs_to_jiffies(ntohs(mld->mld_maxdelay)); max_delay = msecs_to_jiffies(ntohs(mld->mld_maxdelay));
if (max_delay) if (max_delay)
group = &mld->mld_mca; group = &mld->mld_mca;
} else if (skb->len >= sizeof(*mld2q)) { } else {
if (!pskb_may_pull(skb, sizeof(*mld2q))) { if (!pskb_may_pull(skb, sizeof(*mld2q))) {
err = -EINVAL; err = -EINVAL;
goto out; goto out;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment