Commit 25c7794e authored by Matthias Reichl's avatar Matthias Reichl Committed by Greg Kroah-Hartman

dmaengine: bcm2835: Fix cyclic DMA period splitting

commit 2201ac61 upstream.

The code responsible for splitting periods into chunks that
can be handled by the DMA controller missed to update total_len,
the number of bytes processed in the current period, when there
are more chunks to follow.

Therefore total_len was stuck at 0 and the code didn't work at all.
This resulted in a wrong control block layout and audio issues because
the cyclic DMA callback wasn't executing on period boundaries.

Fix this by adding the missing total_len update.
Signed-off-by: default avatarMatthias Reichl <hias@horus.com>
Signed-off-by: default avatarMartin Sperl <kernel@martin.sperl.org>
Tested-by: default avatarClive Messer <clive.messer@digitaldreamtime.co.uk>
Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarAmit Pundir <amit.pundir@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 81135c71
...@@ -251,8 +251,11 @@ static void bcm2835_dma_create_cb_set_length( ...@@ -251,8 +251,11 @@ static void bcm2835_dma_create_cb_set_length(
*/ */
/* have we filled in period_length yet? */ /* have we filled in period_length yet? */
if (*total_len + control_block->length < period_len) if (*total_len + control_block->length < period_len) {
/* update number of bytes in this period so far */
*total_len += control_block->length;
return; return;
}
/* calculate the length that remains to reach period_length */ /* calculate the length that remains to reach period_length */
control_block->length = period_len - *total_len; control_block->length = period_len - *total_len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment