Commit 25cc71d1 authored by Khadija Kamran's avatar Khadija Kamran Committed by Paul Moore

lsm: constify 'sb' parameter in security_quotactl()

SELinux registers the implementation for the "quotactl" hook. Looking at
the function implementation we observe that the parameter "sb" is not
changing.

Mark the "sb" parameter of LSM hook security_quotactl() as "const" since
it will not be changing in the LSM hook.
Signed-off-by: default avatarKhadija Kamran <kamrankhadijadj@gmail.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
parent 0bb80ecc
...@@ -43,7 +43,7 @@ LSM_HOOK(int, 0, capset, struct cred *new, const struct cred *old, ...@@ -43,7 +43,7 @@ LSM_HOOK(int, 0, capset, struct cred *new, const struct cred *old,
const kernel_cap_t *permitted) const kernel_cap_t *permitted)
LSM_HOOK(int, 0, capable, const struct cred *cred, struct user_namespace *ns, LSM_HOOK(int, 0, capable, const struct cred *cred, struct user_namespace *ns,
int cap, unsigned int opts) int cap, unsigned int opts)
LSM_HOOK(int, 0, quotactl, int cmds, int type, int id, struct super_block *sb) LSM_HOOK(int, 0, quotactl, int cmds, int type, int id, const struct super_block *sb)
LSM_HOOK(int, 0, quota_on, struct dentry *dentry) LSM_HOOK(int, 0, quota_on, struct dentry *dentry)
LSM_HOOK(int, 0, syslog, int type) LSM_HOOK(int, 0, syslog, int type)
LSM_HOOK(int, 0, settime, const struct timespec64 *ts, LSM_HOOK(int, 0, settime, const struct timespec64 *ts,
......
...@@ -284,7 +284,7 @@ int security_capable(const struct cred *cred, ...@@ -284,7 +284,7 @@ int security_capable(const struct cred *cred,
struct user_namespace *ns, struct user_namespace *ns,
int cap, int cap,
unsigned int opts); unsigned int opts);
int security_quotactl(int cmds, int type, int id, struct super_block *sb); int security_quotactl(int cmds, int type, int id, const struct super_block *sb);
int security_quota_on(struct dentry *dentry); int security_quota_on(struct dentry *dentry);
int security_syslog(int type); int security_syslog(int type);
int security_settime64(const struct timespec64 *ts, const struct timezone *tz); int security_settime64(const struct timespec64 *ts, const struct timezone *tz);
...@@ -581,7 +581,7 @@ static inline int security_capable(const struct cred *cred, ...@@ -581,7 +581,7 @@ static inline int security_capable(const struct cred *cred,
} }
static inline int security_quotactl(int cmds, int type, int id, static inline int security_quotactl(int cmds, int type, int id,
struct super_block *sb) const struct super_block *sb)
{ {
return 0; return 0;
} }
......
...@@ -957,7 +957,7 @@ int security_capable(const struct cred *cred, ...@@ -957,7 +957,7 @@ int security_capable(const struct cred *cred,
* *
* Return: Returns 0 if permission is granted. * Return: Returns 0 if permission is granted.
*/ */
int security_quotactl(int cmds, int type, int id, struct super_block *sb) int security_quotactl(int cmds, int type, int id, const struct super_block *sb)
{ {
return call_int_hook(quotactl, 0, cmds, type, id, sb); return call_int_hook(quotactl, 0, cmds, type, id, sb);
} }
......
...@@ -1937,7 +1937,7 @@ static inline int may_rename(struct inode *old_dir, ...@@ -1937,7 +1937,7 @@ static inline int may_rename(struct inode *old_dir,
/* Check whether a task can perform a filesystem operation. */ /* Check whether a task can perform a filesystem operation. */
static int superblock_has_perm(const struct cred *cred, static int superblock_has_perm(const struct cred *cred,
struct super_block *sb, const struct super_block *sb,
u32 perms, u32 perms,
struct common_audit_data *ad) struct common_audit_data *ad)
{ {
...@@ -2139,7 +2139,7 @@ static int selinux_capable(const struct cred *cred, struct user_namespace *ns, ...@@ -2139,7 +2139,7 @@ static int selinux_capable(const struct cred *cred, struct user_namespace *ns,
return cred_has_capability(cred, cap, opts, ns == &init_user_ns); return cred_has_capability(cred, cap, opts, ns == &init_user_ns);
} }
static int selinux_quotactl(int cmds, int type, int id, struct super_block *sb) static int selinux_quotactl(int cmds, int type, int id, const struct super_block *sb)
{ {
const struct cred *cred = current_cred(); const struct cred *cred = current_cred();
int rc = 0; int rc = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment