Commit 27d2a2fd authored by Pietro Borrello's avatar Pietro Borrello Committed by Benjamin Tissoires

HID: bigben_worker() remove unneeded check on report_field

bigben_worker() checks report_field to be non-NULL.
The check has been added in commit
918aa1ef ("HID: bigbenff: prevent null pointer dereference")
to prevent a NULL pointer crash.
However, the true root cause was a missing check for output
reports, patched in commit
c7bf714f ("HID: check empty report_list in bigben_probe()"),
where the type-confused report list_entry was overlapping with
a NULL pointer, which was then causing the crash.

Fixes: 918aa1ef ("HID: bigbenff: prevent null pointer dereference")
Signed-off-by: default avatarPietro Borrello <borrello@diag.uniroma1.it>
Link: https://lore.kernel.org/r/20230125-hid-unregister-leds-v4-2-7860c5763c38@diag.uniroma1.itSigned-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
parent 9fefb620
......@@ -197,7 +197,7 @@ static void bigben_worker(struct work_struct *work)
u32 len;
unsigned long flags;
if (bigben->removed || !report_field)
if (bigben->removed)
return;
buf = hid_alloc_report_buf(bigben->report, GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment