Commit 2899836f authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: message: fusion: Switch to attribute groups

struct device supports attribute groups directly but does not support
struct device_attribute directly. Hence switch to attribute groups.

Link: https://lore.kernel.org/r/20211012233558.4066756-6-bvanassche@acm.orgSigned-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a3cf94c9
...@@ -129,7 +129,7 @@ static struct scsi_host_template mptfc_driver_template = { ...@@ -129,7 +129,7 @@ static struct scsi_host_template mptfc_driver_template = {
.sg_tablesize = MPT_SCSI_SG_DEPTH, .sg_tablesize = MPT_SCSI_SG_DEPTH,
.max_sectors = 8192, .max_sectors = 8192,
.cmd_per_lun = 7, .cmd_per_lun = 7,
.shost_attrs = mptscsih_host_attrs, .shost_groups = mptscsih_host_attr_groups,
}; };
/**************************************************************************** /****************************************************************************
......
...@@ -2020,7 +2020,7 @@ static struct scsi_host_template mptsas_driver_template = { ...@@ -2020,7 +2020,7 @@ static struct scsi_host_template mptsas_driver_template = {
.sg_tablesize = MPT_SCSI_SG_DEPTH, .sg_tablesize = MPT_SCSI_SG_DEPTH,
.max_sectors = 8192, .max_sectors = 8192,
.cmd_per_lun = 7, .cmd_per_lun = 7,
.shost_attrs = mptscsih_host_attrs, .shost_groups = mptscsih_host_attr_groups,
.no_write_same = 1, .no_write_same = 1,
}; };
......
...@@ -3218,23 +3218,31 @@ mptscsih_debug_level_store(struct device *dev, struct device_attribute *attr, ...@@ -3218,23 +3218,31 @@ mptscsih_debug_level_store(struct device *dev, struct device_attribute *attr,
static DEVICE_ATTR(debug_level, S_IRUGO | S_IWUSR, static DEVICE_ATTR(debug_level, S_IRUGO | S_IWUSR,
mptscsih_debug_level_show, mptscsih_debug_level_store); mptscsih_debug_level_show, mptscsih_debug_level_store);
struct device_attribute *mptscsih_host_attrs[] = { static struct attribute *mptscsih_host_attrs[] = {
&dev_attr_version_fw, &dev_attr_version_fw.attr,
&dev_attr_version_bios, &dev_attr_version_bios.attr,
&dev_attr_version_mpi, &dev_attr_version_mpi.attr,
&dev_attr_version_product, &dev_attr_version_product.attr,
&dev_attr_version_nvdata_persistent, &dev_attr_version_nvdata_persistent.attr,
&dev_attr_version_nvdata_default, &dev_attr_version_nvdata_default.attr,
&dev_attr_board_name, &dev_attr_board_name.attr,
&dev_attr_board_assembly, &dev_attr_board_assembly.attr,
&dev_attr_board_tracer, &dev_attr_board_tracer.attr,
&dev_attr_io_delay, &dev_attr_io_delay.attr,
&dev_attr_device_delay, &dev_attr_device_delay.attr,
&dev_attr_debug_level, &dev_attr_debug_level.attr,
NULL, NULL,
}; };
EXPORT_SYMBOL(mptscsih_host_attrs); static const struct attribute_group mptscsih_host_attr_group = {
.attrs = mptscsih_host_attrs
};
const struct attribute_group *mptscsih_host_attr_groups[] = {
&mptscsih_host_attr_group,
NULL
};
EXPORT_SYMBOL(mptscsih_host_attr_groups);
EXPORT_SYMBOL(mptscsih_remove); EXPORT_SYMBOL(mptscsih_remove);
EXPORT_SYMBOL(mptscsih_shutdown); EXPORT_SYMBOL(mptscsih_shutdown);
......
...@@ -131,7 +131,7 @@ extern int mptscsih_ioc_reset(MPT_ADAPTER *ioc, int post_reset); ...@@ -131,7 +131,7 @@ extern int mptscsih_ioc_reset(MPT_ADAPTER *ioc, int post_reset);
extern int mptscsih_change_queue_depth(struct scsi_device *sdev, int qdepth); extern int mptscsih_change_queue_depth(struct scsi_device *sdev, int qdepth);
extern u8 mptscsih_raid_id_to_num(MPT_ADAPTER *ioc, u8 channel, u8 id); extern u8 mptscsih_raid_id_to_num(MPT_ADAPTER *ioc, u8 channel, u8 id);
extern int mptscsih_is_phys_disk(MPT_ADAPTER *ioc, u8 channel, u8 id); extern int mptscsih_is_phys_disk(MPT_ADAPTER *ioc, u8 channel, u8 id);
extern struct device_attribute *mptscsih_host_attrs[]; extern const struct attribute_group *mptscsih_host_attr_groups[];
extern struct scsi_cmnd *mptscsih_get_scsi_lookup(MPT_ADAPTER *ioc, int i); extern struct scsi_cmnd *mptscsih_get_scsi_lookup(MPT_ADAPTER *ioc, int i);
extern void mptscsih_taskmgmt_response_code(MPT_ADAPTER *ioc, u8 response_code); extern void mptscsih_taskmgmt_response_code(MPT_ADAPTER *ioc, u8 response_code);
extern void mptscsih_flush_running_cmds(MPT_SCSI_HOST *hd); extern void mptscsih_flush_running_cmds(MPT_SCSI_HOST *hd);
...@@ -843,7 +843,7 @@ static struct scsi_host_template mptspi_driver_template = { ...@@ -843,7 +843,7 @@ static struct scsi_host_template mptspi_driver_template = {
.sg_tablesize = MPT_SCSI_SG_DEPTH, .sg_tablesize = MPT_SCSI_SG_DEPTH,
.max_sectors = 8192, .max_sectors = 8192,
.cmd_per_lun = 7, .cmd_per_lun = 7,
.shost_attrs = mptscsih_host_attrs, .shost_groups = mptscsih_host_attr_groups,
}; };
static int mptspi_write_spi_device_pg1(struct scsi_target *starget, static int mptspi_write_spi_device_pg1(struct scsi_target *starget,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment