Commit 295dc39d authored by Vasily Averin's avatar Vasily Averin Committed by Christoph Hellwig

fs: umount on symlink leaks mnt count

Currently umount on symlink blocks following umount:

/vz is separate mount

# ls /vz/ -al | grep test
drwxr-xr-x.  2 root root       4096 Jul 19 01:14 testdir
lrwxrwxrwx.  1 root root         11 Jul 19 01:16 testlink -> /vz/testdir
# umount -l /vz/testlink
umount: /vz/testlink: not mounted (expected)

# lsof /vz
# umount /vz
umount: /vz: device is busy. (unexpected)

In this case mountpoint_last() gets an extra refcount on path->mnt
Signed-off-by: default avatarVasily Averin <vvs@openvz.org>
Acked-by: default avatarIan Kent <raven@themaw.net>
Acked-by: default avatarJeff Layton <jlayton@primarydata.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 6fcc5420
...@@ -2256,9 +2256,10 @@ mountpoint_last(struct nameidata *nd, struct path *path) ...@@ -2256,9 +2256,10 @@ mountpoint_last(struct nameidata *nd, struct path *path)
goto out; goto out;
} }
path->dentry = dentry; path->dentry = dentry;
path->mnt = mntget(nd->path.mnt); path->mnt = nd->path.mnt;
if (should_follow_link(dentry, nd->flags & LOOKUP_FOLLOW)) if (should_follow_link(dentry, nd->flags & LOOKUP_FOLLOW))
return 1; return 1;
mntget(path->mnt);
follow_mount(path); follow_mount(path);
error = 0; error = 0;
out: out:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment