Commit 29af9309 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

net/9p/trans_fd.c: Fix unsigned return type

The function has an unsigned return type, but returns a negative constant
to indicate an error condition.  The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.

A sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@exists@
identifier f;
constant C;
@@

 unsigned f(...)
 { <+...
*  return -C;
 ...+> }
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e04c4dc8
...@@ -222,7 +222,7 @@ static void p9_conn_cancel(struct p9_conn *m, int err) ...@@ -222,7 +222,7 @@ static void p9_conn_cancel(struct p9_conn *m, int err)
} }
} }
static unsigned int static int
p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt) p9_fd_poll(struct p9_client *client, struct poll_table_struct *pt)
{ {
int ret, n; int ret, n;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment