Commit 2a211f32 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Greg Kroah-Hartman

thunderbolt: Use kcalloc

The advantage of kcalloc is, that will prevent integer overflows
which could result from the multiplication of number of elements
and size and it is also a bit nicer to read.
Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Acked-by: default avatarAndreas Noever <andreas.noever@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 95b4ecbf
...@@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id) ...@@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
nhi->hop_count); nhi->hop_count);
INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work); INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);
nhi->tx_rings = devm_kzalloc(&pdev->dev, nhi->tx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,
nhi->hop_count * sizeof(*nhi->tx_rings), sizeof(*nhi->tx_rings), GFP_KERNEL);
GFP_KERNEL); nhi->rx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,
nhi->rx_rings = devm_kzalloc(&pdev->dev, sizeof(*nhi->rx_rings), GFP_KERNEL);
nhi->hop_count * sizeof(*nhi->rx_rings),
GFP_KERNEL);
if (!nhi->tx_rings || !nhi->rx_rings) if (!nhi->tx_rings || !nhi->rx_rings)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment