Commit 2b1af87a authored by Aaro Koskinen's avatar Aaro Koskinen Committed by Tony Lindgren

arm: omap: sdram-nokia: improve error handling

Actually check for errors: print an error log and return NULL.
Signed-off-by: default avatarAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent e5f5b542
......@@ -223,10 +223,14 @@ struct omap_sdrc_params *nokia_get_sdram_timings(void)
int err = 0;
int i;
for (i = 0; i < ARRAY_SIZE(nokia_timings); i++)
for (i = 0; i < ARRAY_SIZE(nokia_timings); i++) {
err |= sdrc_timings(i, nokia_timings[i].rate,
nokia_timings[i].data);
if (err)
pr_err("%s: error with rate %ld: %d\n", __func__,
nokia_timings[i].rate, err);
}
return &nokia_sdrc_params[0];
return err ? NULL : nokia_sdrc_params;
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment