Commit 2b5160b1 authored by Thadeu Lima de Souza Cascardo's avatar Thadeu Lima de Souza Cascardo Committed by Corey Minyard

ipmi: bail out if init_srcu_struct fails

In case, init_srcu_struct fails (because of memory allocation failure), we
might proceed with the driver initialization despite srcu_struct not being
entirely initialized.

Fixes: 913a89f0 ("ipmi: Don't initialize anything in the core until something uses it")
Signed-off-by: default avatarThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: Corey Minyard <cminyard@mvista.com>
Cc: stable@vger.kernel.org
Message-Id: <20211217154410.1228673-1-cascardo@canonical.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 34f35f8f
...@@ -5392,7 +5392,9 @@ static int ipmi_init_msghandler(void) ...@@ -5392,7 +5392,9 @@ static int ipmi_init_msghandler(void)
if (initialized) if (initialized)
goto out; goto out;
init_srcu_struct(&ipmi_interfaces_srcu); rv = init_srcu_struct(&ipmi_interfaces_srcu);
if (rv)
goto out;
timer_setup(&ipmi_timer, ipmi_timeout, 0); timer_setup(&ipmi_timer, ipmi_timeout, 0);
mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES); mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment