Commit 2e7a5701 authored by Daniel Vetter's avatar Daniel Vetter

drm/doc: Appease sphinx

Mostly this is unexpected indents. But really it's just a
demonstration for my patch, all these issues have been found&fixed
using the correct source file and line number support I just added.
All line numbers have been perfectly accurate.

One issue looked a bit fishy in intel_lrc.c, where I don't quite grok
what sphinx is unhappy about. But since that file looks like it has
never seen a proper kernel-doc parser I figured better to fix in a
separate path.

v2: Use fancy new &drm_device->struct_mutex linking (Jani).

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: linux-doc@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Acked-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
parent 8e01550e
...@@ -2399,7 +2399,7 @@ EXPORT_SYMBOL(drm_atomic_helper_page_flip); ...@@ -2399,7 +2399,7 @@ EXPORT_SYMBOL(drm_atomic_helper_page_flip);
* This is the main helper function provided by the atomic helper framework for * This is the main helper function provided by the atomic helper framework for
* implementing the legacy DPMS connector interface. It computes the new desired * implementing the legacy DPMS connector interface. It computes the new desired
* ->active state for the corresponding CRTC (if the connector is enabled) and * ->active state for the corresponding CRTC (if the connector is enabled) and
* updates it. * updates it.
* *
* Returns: * Returns:
* Returns 0 on success, negative errno numbers on failure. * Returns 0 on success, negative errno numbers on failure.
......
...@@ -535,7 +535,7 @@ EXPORT_SYMBOL(drm_framebuffer_unregister_private); ...@@ -535,7 +535,7 @@ EXPORT_SYMBOL(drm_framebuffer_unregister_private);
* *
* Cleanup framebuffer. This function is intended to be used from the drivers * Cleanup framebuffer. This function is intended to be used from the drivers
* ->destroy callback. It can also be used to clean up driver private * ->destroy callback. It can also be used to clean up driver private
* framebuffers embedded into a larger structure. * framebuffers embedded into a larger structure.
* *
* Note that this function does not remove the fb from active usuage - if it is * Note that this function does not remove the fb from active usuage - if it is
* still used anywhere, hilarity can ensue since userspace could call getfb on * still used anywhere, hilarity can ensue since userspace could call getfb on
......
...@@ -787,7 +787,7 @@ EXPORT_SYMBOL(drm_gem_object_release); ...@@ -787,7 +787,7 @@ EXPORT_SYMBOL(drm_gem_object_release);
* @kref: kref of the object to free * @kref: kref of the object to free
* *
* Called after the last reference to the object has been lost. * Called after the last reference to the object has been lost.
* Must be called holding struct_ mutex * Must be called holding &drm_device->struct_mutex.
* *
* Frees the object * Frees the object
*/ */
......
...@@ -544,6 +544,7 @@ EXPORT_SYMBOL(drm_gtf_mode_complex); ...@@ -544,6 +544,7 @@ EXPORT_SYMBOL(drm_gtf_mode_complex);
* *
* This function is to create the modeline based on the GTF algorithm. * This function is to create the modeline based on the GTF algorithm.
* Generalized Timing Formula is derived from: * Generalized Timing Formula is derived from:
*
* GTF Spreadsheet by Andy Morrish (1/5/97) * GTF Spreadsheet by Andy Morrish (1/5/97)
* available at http://www.vesa.org * available at http://www.vesa.org
* *
......
...@@ -219,10 +219,12 @@ EXPORT_SYMBOL(drm_plane_helper_check_update); ...@@ -219,10 +219,12 @@ EXPORT_SYMBOL(drm_plane_helper_check_update);
* *
* Note that we make some assumptions about hardware limitations that may not be * Note that we make some assumptions about hardware limitations that may not be
* true for all hardware -- * true for all hardware --
* 1) Primary plane cannot be repositioned. *
* 2) Primary plane cannot be scaled. * 1. Primary plane cannot be repositioned.
* 3) Primary plane must cover the entire CRTC. * 2. Primary plane cannot be scaled.
* 4) Subpixel positioning is not supported. * 3. Primary plane must cover the entire CRTC.
* 4. Subpixel positioning is not supported.
*
* Drivers for hardware that don't have these restrictions can provide their * Drivers for hardware that don't have these restrictions can provide their
* own implementation rather than using this helper. * own implementation rather than using this helper.
* *
......
...@@ -5214,14 +5214,14 @@ void intel_edp_drrs_flush(struct drm_device *dev, ...@@ -5214,14 +5214,14 @@ void intel_edp_drrs_flush(struct drm_device *dev,
* *
* DRRS saves power by switching to low RR based on usage scenarios. * DRRS saves power by switching to low RR based on usage scenarios.
* *
* eDP DRRS:- * The implementation is based on frontbuffer tracking implementation. When
* The implementation is based on frontbuffer tracking implementation. * there is a disturbance on the screen triggered by user activity or a periodic
* When there is a disturbance on the screen triggered by user activity or a * system activity, DRRS is disabled (RR is changed to high RR). When there is
* periodic system activity, DRRS is disabled (RR is changed to high RR). * no movement on screen, after a timeout of 1 second, a switch to low RR is
* When there is no movement on screen, after a timeout of 1 second, a switch * made.
* to low RR is made. *
* For integration with frontbuffer tracking code, * For integration with frontbuffer tracking code, intel_edp_drrs_invalidate()
* intel_edp_drrs_invalidate() and intel_edp_drrs_flush() are called. * and intel_edp_drrs_flush() are called.
* *
* DRRS can be further extended to support other internal panels and also * DRRS can be further extended to support other internal panels and also
* the scenario of video playback wherein RR is set based on the rate * the scenario of video playback wherein RR is set based on the rate
......
...@@ -374,8 +374,9 @@ static void intel_fbc_hw_deactivate(struct drm_i915_private *dev_priv) ...@@ -374,8 +374,9 @@ static void intel_fbc_hw_deactivate(struct drm_i915_private *dev_priv)
* @dev_priv: i915 device instance * @dev_priv: i915 device instance
* *
* This function is used to verify the current state of FBC. * This function is used to verify the current state of FBC.
*
* FIXME: This should be tracked in the plane config eventually * FIXME: This should be tracked in the plane config eventually
* instead of queried at runtime for most callers. * instead of queried at runtime for most callers.
*/ */
bool intel_fbc_is_active(struct drm_i915_private *dev_priv) bool intel_fbc_is_active(struct drm_i915_private *dev_priv)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment