Commit 31901264 authored by Antonio Quartulli's avatar Antonio Quartulli Committed by Marek Lindner

batman-adv: fix tt_local_reset_flags() function

Currently the counter of tt_local_entry structures (tt_local_num) is incremented
each time the tt_local_reset_flags() is invoked causing the node to send wrong
TT_REPONSE packets containing a copy of non-initialised memory thus corrupting
other nodes global translation table and making higher level communication
impossible.
Reported-by: default avatarJunkeun Song <jun361@gmail.com>
Signed-off-by: default avatarAntonio Quartulli <ordex@autistici.org>
Acked-by: default avatarJunkeun Song <jun361@gmail.com>
Signed-off-by: default avatarMarek Lindner <lindner_marek@yahoo.de>
parent 8b267b31
...@@ -1668,6 +1668,8 @@ static void tt_local_reset_flags(struct bat_priv *bat_priv, uint16_t flags) ...@@ -1668,6 +1668,8 @@ static void tt_local_reset_flags(struct bat_priv *bat_priv, uint16_t flags)
rcu_read_lock(); rcu_read_lock();
hlist_for_each_entry_rcu(tt_local_entry, node, hlist_for_each_entry_rcu(tt_local_entry, node,
head, hash_entry) { head, hash_entry) {
if (!(tt_local_entry->flags & flags))
continue;
tt_local_entry->flags &= ~flags; tt_local_entry->flags &= ~flags;
atomic_inc(&bat_priv->num_local_tt); atomic_inc(&bat_priv->num_local_tt);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment