Commit 31a6f1a6 authored by Jan Kara's avatar Jan Kara Committed by Dan Williams

dax: Simplify arguments of dax_insert_mapping()

dax_insert_mapping() has lots of arguments and a lot of them is actuall
duplicated by passing vm_fault structure as well. Change the function to
take the same arguments as dax_pmd_insert_mapping().
Reviewed-by: default avatarRoss Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent d81b8a72
...@@ -820,23 +820,30 @@ int dax_writeback_mapping_range(struct address_space *mapping, ...@@ -820,23 +820,30 @@ int dax_writeback_mapping_range(struct address_space *mapping,
} }
EXPORT_SYMBOL_GPL(dax_writeback_mapping_range); EXPORT_SYMBOL_GPL(dax_writeback_mapping_range);
static int dax_insert_mapping(struct address_space *mapping, static sector_t dax_iomap_sector(struct iomap *iomap, loff_t pos)
struct block_device *bdev, struct dax_device *dax_dev, {
sector_t sector, size_t size, void *entry, return iomap->blkno + (((pos & PAGE_MASK) - iomap->offset) >> 9);
struct vm_area_struct *vma, struct vm_fault *vmf) }
static int dax_insert_mapping(struct vm_fault *vmf, struct iomap *iomap,
loff_t pos, void *entry)
{ {
const sector_t sector = dax_iomap_sector(iomap, pos);
struct vm_area_struct *vma = vmf->vma;
struct address_space *mapping = vma->vm_file->f_mapping;
unsigned long vaddr = vmf->address; unsigned long vaddr = vmf->address;
void *ret, *kaddr; void *ret, *kaddr;
pgoff_t pgoff; pgoff_t pgoff;
int id, rc; int id, rc;
pfn_t pfn; pfn_t pfn;
rc = bdev_dax_pgoff(bdev, sector, size, &pgoff); rc = bdev_dax_pgoff(iomap->bdev, sector, PAGE_SIZE, &pgoff);
if (rc) if (rc)
return rc; return rc;
id = dax_read_lock(); id = dax_read_lock();
rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(size), &kaddr, &pfn); rc = dax_direct_access(iomap->dax_dev, pgoff, PHYS_PFN(PAGE_SIZE),
&kaddr, &pfn);
if (rc < 0) { if (rc < 0) {
dax_read_unlock(id); dax_read_unlock(id);
return rc; return rc;
...@@ -936,11 +943,6 @@ int __dax_zero_page_range(struct block_device *bdev, ...@@ -936,11 +943,6 @@ int __dax_zero_page_range(struct block_device *bdev,
} }
EXPORT_SYMBOL_GPL(__dax_zero_page_range); EXPORT_SYMBOL_GPL(__dax_zero_page_range);
static sector_t dax_iomap_sector(struct iomap *iomap, loff_t pos)
{
return iomap->blkno + (((pos & PAGE_MASK) - iomap->offset) >> 9);
}
static loff_t static loff_t
dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *data, dax_iomap_actor(struct inode *inode, loff_t pos, loff_t length, void *data,
struct iomap *iomap) struct iomap *iomap)
...@@ -1087,7 +1089,6 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf, ...@@ -1087,7 +1089,6 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf,
struct inode *inode = mapping->host; struct inode *inode = mapping->host;
unsigned long vaddr = vmf->address; unsigned long vaddr = vmf->address;
loff_t pos = (loff_t)vmf->pgoff << PAGE_SHIFT; loff_t pos = (loff_t)vmf->pgoff << PAGE_SHIFT;
sector_t sector;
struct iomap iomap = { 0 }; struct iomap iomap = { 0 };
unsigned flags = IOMAP_FAULT; unsigned flags = IOMAP_FAULT;
int error, major = 0; int error, major = 0;
...@@ -1140,9 +1141,9 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf, ...@@ -1140,9 +1141,9 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf,
goto error_finish_iomap; goto error_finish_iomap;
} }
sector = dax_iomap_sector(&iomap, pos);
if (vmf->cow_page) { if (vmf->cow_page) {
sector_t sector = dax_iomap_sector(&iomap, pos);
switch (iomap.type) { switch (iomap.type) {
case IOMAP_HOLE: case IOMAP_HOLE:
case IOMAP_UNWRITTEN: case IOMAP_UNWRITTEN:
...@@ -1175,8 +1176,7 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf, ...@@ -1175,8 +1176,7 @@ static int dax_iomap_pte_fault(struct vm_fault *vmf,
count_memcg_event_mm(vmf->vma->vm_mm, PGMAJFAULT); count_memcg_event_mm(vmf->vma->vm_mm, PGMAJFAULT);
major = VM_FAULT_MAJOR; major = VM_FAULT_MAJOR;
} }
error = dax_insert_mapping(mapping, iomap.bdev, iomap.dax_dev, error = dax_insert_mapping(vmf, &iomap, pos, entry);
sector, PAGE_SIZE, entry, vmf->vma, vmf);
/* -EBUSY is fine, somebody else faulted on the same PTE */ /* -EBUSY is fine, somebody else faulted on the same PTE */
if (error == -EBUSY) if (error == -EBUSY)
error = 0; error = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment