Commit 324ed533 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

[media] dw2102: some missing unlocks on error

We recently introduced some new error paths but the unlocks are missing.
Fixes: 0065a79a ('[media] dw2102: Don't use dynamic static allocation')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 1cdbcc5d
...@@ -292,6 +292,7 @@ static int dw2102_serit_i2c_transfer(struct i2c_adapter *adap, ...@@ -292,6 +292,7 @@ static int dw2102_serit_i2c_transfer(struct i2c_adapter *adap,
static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], int num) static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], int num)
{ {
struct dvb_usb_device *d = i2c_get_adapdata(adap); struct dvb_usb_device *d = i2c_get_adapdata(adap);
int ret;
if (!d) if (!d)
return -ENODEV; return -ENODEV;
...@@ -307,7 +308,8 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms ...@@ -307,7 +308,8 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms
if (2 + msg[1].len > sizeof(ibuf)) { if (2 + msg[1].len > sizeof(ibuf)) {
warn("i2c rd: len=%d is too big!\n", warn("i2c rd: len=%d is too big!\n",
msg[1].len); msg[1].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[0].addr << 1; obuf[0] = msg[0].addr << 1;
...@@ -331,7 +333,8 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms ...@@ -331,7 +333,8 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms
if (2 + msg[0].len > sizeof(obuf)) { if (2 + msg[0].len > sizeof(obuf)) {
warn("i2c wr: len=%d is too big!\n", warn("i2c wr: len=%d is too big!\n",
msg[1].len); msg[1].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[0].addr << 1; obuf[0] = msg[0].addr << 1;
...@@ -348,7 +351,8 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms ...@@ -348,7 +351,8 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms
if (2 + msg[0].len > sizeof(obuf)) { if (2 + msg[0].len > sizeof(obuf)) {
warn("i2c wr: len=%d is too big!\n", warn("i2c wr: len=%d is too big!\n",
msg[1].len); msg[1].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[0].addr << 1; obuf[0] = msg[0].addr << 1;
...@@ -377,15 +381,17 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms ...@@ -377,15 +381,17 @@ static int dw2102_earda_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg ms
break; break;
} }
ret = num;
unlock:
mutex_unlock(&d->i2c_mutex); mutex_unlock(&d->i2c_mutex);
return num; return ret;
} }
static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], int num) static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], int num)
{ {
struct dvb_usb_device *d = i2c_get_adapdata(adap); struct dvb_usb_device *d = i2c_get_adapdata(adap);
int len, i, j; int len, i, j, ret;
if (!d) if (!d)
return -ENODEV; return -ENODEV;
...@@ -421,7 +427,8 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], i ...@@ -421,7 +427,8 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], i
if (2 + msg[j].len > sizeof(ibuf)) { if (2 + msg[j].len > sizeof(ibuf)) {
warn("i2c rd: len=%d is too big!\n", warn("i2c rd: len=%d is too big!\n",
msg[j].len); msg[j].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
dw210x_op_rw(d->udev, 0xc3, dw210x_op_rw(d->udev, 0xc3,
...@@ -457,7 +464,8 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], i ...@@ -457,7 +464,8 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], i
if (2 + msg[j].len > sizeof(obuf)) { if (2 + msg[j].len > sizeof(obuf)) {
warn("i2c wr: len=%d is too big!\n", warn("i2c wr: len=%d is too big!\n",
msg[j].len); msg[j].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[j].addr << 1; obuf[0] = msg[j].addr << 1;
...@@ -472,15 +480,18 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], i ...@@ -472,15 +480,18 @@ static int dw2104_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], i
} }
} }
ret = num;
unlock:
mutex_unlock(&d->i2c_mutex); mutex_unlock(&d->i2c_mutex);
return num; return ret;
} }
static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
int num) int num)
{ {
struct dvb_usb_device *d = i2c_get_adapdata(adap); struct dvb_usb_device *d = i2c_get_adapdata(adap);
int ret;
int i; int i;
if (!d) if (!d)
...@@ -497,7 +508,8 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -497,7 +508,8 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
if (2 + msg[1].len > sizeof(ibuf)) { if (2 + msg[1].len > sizeof(ibuf)) {
warn("i2c rd: len=%d is too big!\n", warn("i2c rd: len=%d is too big!\n",
msg[1].len); msg[1].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[0].addr << 1; obuf[0] = msg[0].addr << 1;
obuf[1] = msg[0].len; obuf[1] = msg[0].len;
...@@ -521,7 +533,8 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -521,7 +533,8 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
if (2 + msg[0].len > sizeof(obuf)) { if (2 + msg[0].len > sizeof(obuf)) {
warn("i2c wr: len=%d is too big!\n", warn("i2c wr: len=%d is too big!\n",
msg[0].len); msg[0].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[0].addr << 1; obuf[0] = msg[0].addr << 1;
obuf[1] = msg[0].len; obuf[1] = msg[0].len;
...@@ -547,9 +560,11 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -547,9 +560,11 @@ static int dw3101_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
msg[i].flags == 0 ? ">>>" : "<<<"); msg[i].flags == 0 ? ">>>" : "<<<");
debug_dump(msg[i].buf, msg[i].len, deb_xfer); debug_dump(msg[i].buf, msg[i].len, deb_xfer);
} }
ret = num;
unlock:
mutex_unlock(&d->i2c_mutex); mutex_unlock(&d->i2c_mutex);
return num; return ret;
} }
static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
...@@ -557,7 +572,7 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -557,7 +572,7 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
{ {
struct dvb_usb_device *d = i2c_get_adapdata(adap); struct dvb_usb_device *d = i2c_get_adapdata(adap);
struct usb_device *udev; struct usb_device *udev;
int len, i, j; int len, i, j, ret;
if (!d) if (!d)
return -ENODEV; return -ENODEV;
...@@ -609,7 +624,8 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -609,7 +624,8 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
if (msg[j].len > sizeof(ibuf)) { if (msg[j].len > sizeof(ibuf)) {
warn("i2c rd: len=%d is too big!\n", warn("i2c rd: len=%d is too big!\n",
msg[j].len); msg[j].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
dw210x_op_rw(d->udev, 0x91, 0, 0, dw210x_op_rw(d->udev, 0x91, 0, 0,
...@@ -643,7 +659,8 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -643,7 +659,8 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
if (2 + msg[j].len > sizeof(obuf)) { if (2 + msg[j].len > sizeof(obuf)) {
warn("i2c wr: len=%d is too big!\n", warn("i2c wr: len=%d is too big!\n",
msg[j].len); msg[j].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[j + 1].len; obuf[0] = msg[j + 1].len;
...@@ -662,7 +679,8 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -662,7 +679,8 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
if (2 + msg[j].len > sizeof(obuf)) { if (2 + msg[j].len > sizeof(obuf)) {
warn("i2c wr: len=%d is too big!\n", warn("i2c wr: len=%d is too big!\n",
msg[j].len); msg[j].len);
return -EOPNOTSUPP; ret = -EOPNOTSUPP;
goto unlock;
} }
obuf[0] = msg[j].len + 1; obuf[0] = msg[j].len + 1;
obuf[1] = (msg[j].addr << 1); obuf[1] = (msg[j].addr << 1);
...@@ -676,9 +694,11 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], ...@@ -676,9 +694,11 @@ static int s6x0_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
} }
} }
} }
ret = num;
unlock:
mutex_unlock(&d->i2c_mutex); mutex_unlock(&d->i2c_mutex);
return num; return ret;
} }
static int su3000_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[], static int su3000_i2c_transfer(struct i2c_adapter *adap, struct i2c_msg msg[],
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment